Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a release-time guardrail to ensure the Git tag being built matches the CLI’s hardcoded Version, preventing accidental mismatched releases.
Changes:
- Updates
cmd/version.go’sVersionstring to0.0.10. - Adds a version-validation step to the release GitHub Actions workflow.
- Introduces a shell script to compare the pushed tag against
cmd/version.go.
Show a summary per file
| File | Description |
|---|---|
cmd/version.go |
Updates the CLI’s reported version string. |
.github/workflows/release.yml |
Runs a version-check step during tag-based releases. |
.github/workflows/check-version.sh |
Extracts the version from code and compares it with the release tag. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 3
nicodes
previously approved these changes
Apr 7, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
nicodes
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/github/spark/issues/2259
Our typical release process for this component is just to set a tagged release and let that go. This has the downside that our binary also thinks it knows its version over in cmd/version.go.
Rather than do something elaborate when we're not releasing this often, this PR simply adds a guardrail that will fail the release if the versions don't align. In that case, the move is to remove the partial release/tag, commit the updated version, and then release.
This should be sufficient for the moment, and if we get working on this more often to where it's an annoyance, we can put a more thorough system in place.