Commit 554e547
Validate version on release (#22)
Fixes github/spark#2259
Our typical release process for this component is just to set a tagged
release and let that go. This has the downside that our binary also
thinks it knows its version over in cmd/version.go.
Rather than do something elaborate when we're not releasing this often,
this PR simply adds a guardrail that will fail the release if the
versions don't align. In that case, the move is to remove the partial
release/tag, commit the updated version, and then release.
This should be sufficient for the moment, and if we get working on this
more often to where it's an annoyance, we can put a more thorough system
in place.
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>1 parent fd97ceb commit 554e547
3 files changed
Lines changed: 21 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
16 | 21 | | |
17 | 22 | | |
18 | 23 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
0 commit comments