Repository navigation
Fix Winget PR description version wording - #267
Merged
Merged
Conversation
The generated description repeated the version ("to version 1.7.5 from
v1.7.5") because the tag was rendered next to the version. Point the
description at the release notes instead.
Co-Authored-By: siGit Code v1.7.5-acp <noreply@sigit.si>
|
siGit Code Review couldn't finish this review: the model service was unavailable. Mention @sigit-code-review to try again. Automated review by siGit Code Review · commit 83ba964 · see the review dashboard |
paydii
approved these changes
Oct 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #262
The Winget PR description said "Updates getSigit.siGitCode to version 1.7.5 from v1.7.5", which repeated the tag instead of pointing at the release notes. The workflow now writes the version and a link to the GitHub release:
Adds getSigit.siGitCode version 1.7.5. Release notes: <release URL>Updates getSigit.siGitCode to version 1.7.5. Release notes: <release URL>The tag is no longer part of the sentence, so the version reads as a version. The release link comes from the same tag the workflow already resolves, turned into
https://github.com/getsigit/sigit/releases/tag/<tag>.Only the description changed. The issue-first flow and the two-token setup (
WINGET_ISSUE_TOKENfor the issue,WINGET_PR_TOKENfor the PR) are untouched.cargo fmt -- --check,cargo clippy --tests -- -D warningsandcargo test --lockedpass. The workflow YAML parses.