Skip to content

ref(asgi): Remove transaction_style parameter - #7796

Merged
alexander-alderman-webb merged 6 commits into
major/3.0from
webb/litestar/transaction-style
Oct 1, 2026
Merged

alexander-alderman-webb merged 6 commits into
major/3.0from
webb/litestar/transaction-style

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Remove the transaction_style parameter from all integrations that rely on SentryAsgiMiddleware, inlining the branches that set the route template as the segment name (i.e., transaction_style="url").

Issues

Closes #7765
Closes #7760
Closes #7762
Closes #7759
Closes #7762

Reminders

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 58733 passed | ❌ 1 failed | ⏭️ 2727 skipped | Total: 61461 | Pass Rate: 95.56% | Execution Time: 161m 40s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -75595
Passed Tests 📉 -71101
Failed Tests 📉 -1
Skipped Tests 📉 -4493

➕ New Tests (1)

View new tests
  • test_async_transport_rate_limiting_with_concurrency
    • File: tests.test_transport
    • Status: ❌ Failing

➖ Removed Tests (1)

View removed tests
  • test_binary_content_encoding_image_url[True-False]
    • File: tests.integrations.litellm.test_litellm

❌ Failed Tests

test_async_transport_rate_limiting_with_concurrency

File: tests.test_transport
Suite: py3.8-common
Error: AssertionError: assert False is True + where False = _check_disabled('error') + where _check_disabled = <sentry_sdk.transport.AsyncHttpTransport object at 0x7f77a83b3250>._check_disabled + where <sentry_sdk.transport.AsyncHttpTransport object at 0x7f77a83b3250> = <sentry_sdk.client._Client object at 0x7f7774b723a0>.transport

Stack Trace
tests/test_transport.py:1037: in test_async_transport_rate_limiting_with_concurrency
    assert client.transport._check_disabled("error") is True
E   AssertionError: assert False is True
E    +  where False = _check_disabled('error')
E    +    where _check_disabled = <sentry_sdk.transport.AsyncHttpTransport object at 0x7f77a83b3250>._check_disabled
E    +      where <sentry_sdk.transport.AsyncHttpTransport object at 0x7f77a83b3250> = <sentry_sdk.client._Client object at 0x7f7774b723a0>.transport

✅ Patch coverage is 100.00%. Project has 2077 uncovered lines.
❌ Project coverage is 90.13%. Comparing base (61a562c) to head (5c17a6a).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.34%    90.13%    -0.21%
==========================================
  Files          199       183       -16
  Lines        26524     21047     -5477
  Branches      9864      7370     -2494
==========================================
+ Hits         23962     18970     -4992
- Misses        2562      2077      -485
- Partials      1495      1223      -272

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb force-pushed the webb/litestar/transaction-style branch 5 times, most recently from 22b0660 to baaf852 Compare October 1, 2026 07:49
@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review October 1, 2026 07:55
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner October 1, 2026 07:55
@alexander-alderman-webb
alexander-alderman-webb force-pushed the webb/litestar/transaction-style branch from baaf852 to 42ca897 Compare October 1, 2026 07:58
@alexander-alderman-webb
alexander-alderman-webb force-pushed the webb/litestar/transaction-style branch from 42ca897 to 7b6c588 Compare October 1, 2026 08:00

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread sentry_sdk/integrations/asgi.py Resolved
@alexander-alderman-webb
alexander-alderman-webb marked this pull request as draft October 1, 2026 08:11

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ab325ea. Configure here.

Comment thread sentry_sdk/integrations/asgi.py Resolved
@alexander-alderman-webb
alexander-alderman-webb force-pushed the webb/litestar/transaction-style branch from ab325ea to cecb870 Compare October 1, 2026 08:15
@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review October 1, 2026 08:18

@sentrivana sentrivana left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, see one suggestion

Comment thread sentry_sdk/integrations/asgi.py Resolved
@alexander-alderman-webb
alexander-alderman-webb merged commit 29d9d8f into major/3.0 Oct 1, 2026
144 of 147 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/litestar/transaction-style branch October 1, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants