always set SegmentNameSource.ROUTE in asgi.py

Author: alexander-alderman-webb

sentry_sdk/integrations/asgi.py

@@ -202,17 +202,14 @@ async def _run_app(
                     )
 
                     ty = scope["type"]
-                    (
-                        transaction_name,
-                        transaction_source,
-                    ) = self._get_transaction_name_and_source(scope)
+                    transaction_name = self._get_transaction_name(scope)
 
                     method = scope.get("method", "").upper()
 
                     span: "Optional[ContextManager[Optional[Span]]]" = None
                     attributes: "Attributes" = {
                         "sentry.segment.name.source": getattr(
-                            transaction_source, "value", transaction_source
+                            SegmentNameSource.ROUTE, "value", SegmentNameSource.ROUTE
                         ),
                         "sentry.origin": self.span_origin,
                         "network.protocol.name": ty,
@@ -346,9 +343,9 @@ def event_processor(
             ]
         )
         if not already_set:
-            name, source = self._get_transaction_name_and_source(asgi_scope)
+            name = self._get_transaction_name(asgi_scope)
             event["transaction"] = name
-            event["transaction_info"] = {"source": source}
+            event["transaction_info"] = {"source": SegmentNameSource.ROUTE}
 
         return event
 
@@ -358,11 +355,8 @@ def event_processor(
     # data to your liking it's recommended to use the `before_send` callback
     # for that.
 
-    def _get_transaction_name_and_source(
-        self: "SentryAsgiMiddleware", asgi_scope: "Any"
-    ) -> "Tuple[str, str]":
+    def _get_transaction_name(self: "SentryAsgiMiddleware", asgi_scope: "Any") -> "str":
         name = None
-        source = SegmentNameSource.URL
 
         # FastAPI includes the route object in the scope to let Sentry extract the
         # path from it for the transaction name
@@ -382,11 +376,9 @@ def _get_transaction_name_and_source(
             )
 
         if name is None:
-            name = _DEFAULT_TRANSACTION_NAME
-            source = SegmentNameSource.ROUTE
-            return name, source
+            return _DEFAULT_TRANSACTION_NAME
 
-        return name, source
+        return name
 
     def _get_segment_name_and_source(
         self: "SentryAsgiMiddleware", asgi_scope: "Any"