Skip to content

test(starlette): Expect parametrized route in starlette>=1.7 #7789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-alderman-webb merged 1 commit into from
Sep 30, 2026
Merged

test(starlette): Expect parametrized route in starlette>=1.7 #7789

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions tests/integrations/starlette/test_starlette.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1025,7 +1025,7 @@ def test_transaction_style(
assert event["transaction_info"] == {"source": expected_source}


def test_host_route_path_has_url_source(sentry_init, capture_events):
def test_hosted_route_transaction_info(sentry_init, capture_events):
sentry_init(
integrations=[StarletteIntegration(transaction_style="url")],
traces_sample_rate=1.0,
Expand All @@ -1046,8 +1046,13 @@ async def hosted_endpoint(request):
client.get("/users/123456", headers={"Host": "subapp"})

(event,) = events
assert event["transaction"].endswith("/users/123456")
assert event["transaction_info"] == {"source": "url"}
# Starlette starting setting scope["route"] with https://github.com/Kludex/starlette/commit/9c594b56e8da9c3d8c35baa40f357e7bc94f6d02
if STARLETTE_VERSION >= (1, 7):
assert event["transaction"] == "/users/{user_id}"
assert event["transaction_info"] == {"source": "route"}
else:
assert event["transaction"].endswith("/users/123456")
assert event["transaction_info"] == {"source": "url"}


@pytest.mark.parametrize(
Expand Down
Loading