Skip to content

test(starlette): Expect parametrized route in starlette>=1.7 - #7789

Merged
alexander-alderman-webb merged 1 commit into
masterfrom
webb/starlette/route
Sep 30, 2026
Merged

alexander-alderman-webb merged 1 commit into
masterfrom
webb/starlette/route

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Description

The ASGI integration sets the parametrized path as the transaction name from the ASGI scope "route" property.
Starlette started setting the property in new versions.

Issues

Closes #7778

Reminders

@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner September 30, 2026 10:49
@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 130355 passed | ⏭️ 7185 skipped | Total: 137540 | Pass Rate: 94.78% | Execution Time: 454m 31s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +78
Passed Tests 📈 +62
Failed Tests —
Skipped Tests 📈 +16

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2547 uncovered lines.
✅ Project coverage is 90.29%. Comparing base (e1f5e70) to head (21da8da).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
+ Coverage    90.26%    90.29%    +0.03%
==========================================
  Files          195       195         —
  Lines        26226     26226         —
  Branches      9776      9776         —
==========================================
+ Hits         23672     23679        +7
- Misses        2554      2547        -7
- Partials      1484      1484         —

Generated by Codecov Action

@alexander-alderman-webb alexander-alderman-webb changed the title test(starlette): Expect parametrized route in starlette>=1.7 test(starlette): Expect parametrized route in starlette>=1.7 Sep 30, 2026
@alexander-alderman-webb
alexander-alderman-webb merged commit 6c2ec6e into master Sep 30, 2026
166 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/starlette/route branch September 30, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Starlette CI failures

2 participants