Skip to content

fix(redis): Close spans on exception in execute_command #7409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sentrivana merged 3 commits into from
Sep 7, 2026
Merged

fix(redis): Close spans on exception in execute_command #7409

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
934046e
fix(redis): Close spans on exception in execute_command
sentrivana Sep 7, 2026
55be5e3
Merge branch 'major/3.0' into ivana/major/redis-wrap-execute-command
sentrivana Sep 7, 2026
9e4cee4
fix order
sentrivana Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions sentry_sdk/integrations/redis/_async_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,14 +152,17 @@ async def _sentry_execute_command(
set_db_data_fn(db_span, self)
_set_client_data(db_span, is_cluster, name, *args)

value = await old_execute_command(self, name, *args, **kwargs)
try:
value = await old_execute_command(self, name, *args, **kwargs)

db_span.end()
if cache_span:
_set_cache_data(cache_span, self, cache_properties, value)

if cache_span:
_set_cache_data(cache_span, self, cache_properties, value)
cache_span.end()
return value
finally:
db_span.end()

return value
if cache_span:
cache_span.end()
Comment thread
sentrivana marked this conversation as resolved.
Resolved

cls.execute_command = _sentry_execute_command # type: ignore
Loading