Skip to content

fix(redis): Close spans on exception in execute_command - #7409

Merged
sentrivana merged 3 commits into
major/3.0from
ivana/major/redis-wrap-execute-command
Sep 7, 2026
Merged

sentrivana merged 3 commits into
major/3.0from
ivana/major/redis-wrap-execute-command

Conversation

@sentrivana

Copy link
Copy Markdown
Collaborator

Not introduced recently, but worth improving regardless. #5005 (comment)

@sentrivana
sentrivana marked this pull request as ready for review September 7, 2026 09:42
@sentrivana
sentrivana requested a review from a team as a code owner September 7, 2026 09:42

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 55be5e3. Configure here.

@github-actions

github-actions Bot commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 78162 passed | ⏭️ 3585 skipped | Total: 81747 | Pass Rate: 95.61% | Execution Time: 252m 12s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -55959
Passed Tests 📉 -52422
Failed Tests —
Skipped Tests 📉 -3537

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2271 uncovered lines.
❌ Project coverage is 90.17%. Comparing base (57a7298) to head (9e4cee4).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.25%    90.17%    -0.08%
==========================================
  Files          193       185        -8
  Lines        25725     23096     -2629
  Branches      9494      8444     -1050
==========================================
+ Hits         23217     20825     -2392
- Misses        2508      2271      -237
- Partials      1432      1355       -77

Generated by Codecov Action

@sentrivana
sentrivana merged commit 7a758b9 into major/3.0 Sep 7, 2026
149 checks passed
@sentrivana
sentrivana deleted the ivana/major/redis-wrap-execute-command branch September 7, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants