Skip to content

fix: Remove by accident exported convention #24542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JPeer264 merged 1 commit into from
Sep 21, 2026
Merged

fix: Remove by accident exported convention #24542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MIGRATION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,7 +872,7 @@ Attribute availability remains runtime-dependent. For example, browser and Worke

Span attributes now use the shared `@sentry/conventions` package under the hood.
The deprecated `semanticAttributes` re-export was removed. Import span attribute constants from `@sentry/core` directly.
`SEMANTIC_ATTRIBUTE_SENTRY_SOURCE` (`sentry.source`) was removed. Use `SENTRY_SEGMENT_NAME_SOURCE` (`sentry.segment.name.source`) instead.
`SEMANTIC_ATTRIBUTE_SENTRY_SOURCE` (`sentry.source`) was removed. Use the `sentry.segment.name.source` attribute instead. The SDK does not export a constant for it, import `SENTRY_SEGMENT_NAME_SOURCE` from `@sentry/conventions/attributes` or use the string.

@Lms24 Lms24 Sep 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd omit the conventions package here as long as we haven't decided if we want users to use that package.

Suggested change
`SEMANTIC_ATTRIBUTE_SENTRY_SOURCE` (`sentry.source`) was removed. Use the `sentry.segment.name.source` attribute instead. The SDK does not export a constant for it, import `SENTRY_SEGMENT_NAME_SOURCE` from `@sentry/conventions/attributes` or use the string.
`SEMANTIC_ATTRIBUTE_SENTRY_SOURCE` (`sentry.source`) was removed. Use the `sentry.segment.name.source` attribute instead and make sure to only set it on segment/root spans.

`sentry.segment.name.source` is only set on the root span. Setting it on a child span is a no-op: `setAttribute` ignores it, and a value passed in a child span's initial attributes is dropped when the span is linked to its parent.

### Span operation (`op`) changes
Expand Down
1 change: 0 additions & 1 deletion packages/astro/src/index.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ export {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SENTRY_SEGMENT_NAME_SOURCE,
setContext,
setConversationId,
setCurrentClient,
Expand Down
1 change: 0 additions & 1 deletion packages/aws-serverless/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ export {
parameterize,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SENTRY_SEGMENT_NAME_SOURCE,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
dataloaderIntegration,
expressIntegration,
Expand Down
1 change: 0 additions & 1 deletion packages/browser/src/exports.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ export {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SENTRY_SEGMENT_NAME_SOURCE,
} from '@sentry/core';

export { WINDOW } from './helpers';
Expand Down
1 change: 0 additions & 1 deletion packages/bun/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ export {
parameterize,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SENTRY_SEGMENT_NAME_SOURCE,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
dataloaderIntegration,
expressIntegration,
Expand Down
1 change: 0 additions & 1 deletion packages/cloudflare/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ export {
consoleIntegration,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SENTRY_SEGMENT_NAME_SOURCE,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
spanToStaticSpanJSON,
spanToJSON,
Expand Down
1 change: 0 additions & 1 deletion packages/core/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ export type { OfflineStore, OfflineTransportOptions } from './transports/offline
export type { IntegrationIndex } from './integration';
export * from './tracing';
export * from './semanticAttributes';
export { SENTRY_SEGMENT_NAME_SOURCE } from '@sentry/conventions/attributes';
export * from './tracing/spans/spanNames';
export type { RawAttributes } from './attributes';
export { createEventEnvelope, createSessionEnvelope } from './envelope';
Expand Down
1 change: 0 additions & 1 deletion packages/deno/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ export {
zodErrorsIntegration,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SENTRY_SEGMENT_NAME_SOURCE,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
startSession,
captureSession,
Expand Down
1 change: 0 additions & 1 deletion packages/elysia/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ export {
parameterize,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SENTRY_SEGMENT_NAME_SOURCE,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
dataloaderIntegration,
expressIntegration,
Expand Down
1 change: 0 additions & 1 deletion packages/google-cloud-serverless/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ export {
parameterize,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SENTRY_SEGMENT_NAME_SOURCE,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
dataloaderIntegration,
expressIntegration,
Expand Down
1 change: 0 additions & 1 deletion packages/node/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,6 @@ export { defaultStackParser, getSentryRelease } from './sdk/api';
export { makeNodeTransport } from './transports';
export { createGetModuleFromFilename } from './utils/module';

export { SENTRY_SEGMENT_NAME_SOURCE } from '@sentry/conventions/attributes';
export { eveConversationHook, getInstrumentedModuleNames } from '@sentry/server-utils';
export { httpServerIntegration } from './integrations/http/httpServerIntegration';
export { httpServerSpansIntegration } from './integrations/http/httpServerSpansIntegration';
Expand Down
1 change: 0 additions & 1 deletion packages/remix/src/cloudflare/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ export {
zodErrorsIntegration,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SENTRY_SEGMENT_NAME_SOURCE,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
spanToStaticSpanJSON,
spanToJSON,
Expand Down
1 change: 0 additions & 1 deletion packages/remix/src/server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ export {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SENTRY_SEGMENT_NAME_SOURCE,
setContext,
setCurrentClient,
setExtra,
Expand Down
1 change: 0 additions & 1 deletion packages/solidstart/src/server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ export {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SENTRY_SEGMENT_NAME_SOURCE,
setContext,
setCurrentClient,
setExtra,
Expand Down
1 change: 0 additions & 1 deletion packages/sveltekit/src/server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ export {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SENTRY_SEGMENT_NAME_SOURCE,
setContext,
setCurrentClient,
setExtra,
Expand Down
1 change: 0 additions & 1 deletion packages/sveltekit/src/worker/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ export {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SENTRY_SEGMENT_NAME_SOURCE,
setContext,
setCurrentClient,
setExtra,
Expand Down
1 change: 0 additions & 1 deletion packages/vercel-edge/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ export {
consoleIntegration,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SENTRY_SEGMENT_NAME_SOURCE,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
spanToStaticSpanJSON,
spanToJSON,
Expand Down
Loading