fix: Remove by accident exported convention - #24542
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
Lms24
approved these changes
Sep 21, 2026
| Span attributes now use the shared `@sentry/conventions` package under the hood. | ||
| The deprecated `semanticAttributes` re-export was removed. Import span attribute constants from `@sentry/core` directly. | ||
| `SEMANTIC_ATTRIBUTE_SENTRY_SOURCE` (`sentry.source`) was removed. Use `SENTRY_SEGMENT_NAME_SOURCE` (`sentry.segment.name.source`) instead. | ||
| `SEMANTIC_ATTRIBUTE_SENTRY_SOURCE` (`sentry.source`) was removed. Use the `sentry.segment.name.source` attribute instead. The SDK does not export a constant for it, import `SENTRY_SEGMENT_NAME_SOURCE` from `@sentry/conventions/attributes` or use the string. |
Member
There was a problem hiding this comment.
I'd omit the conventions package here as long as we haven't decided if we want users to use that package.
Suggested change
| `SEMANTIC_ATTRIBUTE_SENTRY_SOURCE` (`sentry.source`) was removed. Use the `sentry.segment.name.source` attribute instead. The SDK does not export a constant for it, import `SENTRY_SEGMENT_NAME_SOURCE` from `@sentry/conventions/attributes` or use the string. | |
| `SEMANTIC_ATTRIBUTE_SENTRY_SOURCE` (`sentry.source`) was removed. Use the `sentry.segment.name.source` attribute instead and make sure to only set it on segment/root spans. |
JPeer264
marked this pull request as ready for review
September 21, 2026 12:05
JPeer264
requested review from
isaacs,
logaretm,
mydea,
nicohrubec and
s1gr1d
and removed request for
a team
September 21, 2026 12:05
JPeer264
added a commit
that referenced
this pull request
Sep 21, 2026
Overlooked a change #24542 (comment)
47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.