perf(bundler-plugins): Use fast component annotation for HTML injection mode - #24440
Merged
Merged
Conversation
timfish
added this pull request to stack #24441
September 16, 2026 11:32
Contributor
size-limit report 📦
|
timfish
force-pushed
the
feat/fast-annotation-html-injection
branch
from
September 16, 2026 16:09
b9714bb to
f9fc3b3
Compare
Base automatically changed from
feat/rollup-vite-fast-component-annotation
to
develop
September 16, 2026 17:02
timfish
force-pushed
the
feat/fast-annotation-html-injection
branch
from
September 16, 2026 17:02
f9fc3b3 to
66f9e6b
Compare
timfish
marked this pull request as ready for review
September 16, 2026 17:02
timfish
force-pushed
the
feat/fast-annotation-html-injection
branch
2 times, most recently
from
September 20, 2026 12:51
d6d9305 to
4e4aaf1
Compare
Contributor
|
👋 @chargome — Please review this PR when you get a chance! |
timfish
force-pushed
the
feat/fast-annotation-html-injection
branch
from
September 21, 2026 22:02
4e4aaf1 to
c1264e7
Compare
timfish
force-pushed
the
feat/fast-annotation-html-injection
branch
from
September 22, 2026 10:50
c1264e7 to
fea650c
Compare
chargome
approved these changes
Sep 23, 2026
timfish
added a commit
that referenced
this pull request
Sep 23, 2026
…Turbopack (#24448) Stacked on #24440. Webpack and the Next.js Turbopack loader still annotated React components with Babel. This PR moves them to the fast oxc-based path, so every bundler integration now uses it. Babel stays as the fallback when `oxc-parser` cannot load or cannot parse a file. The next PR in the stack removes that fallback. `createComponentNameAnnotateHooks` now tries the fast path first and uses Babel only when the fast path does not handle the file. Webpack, the Rollup and Vite plugins, and the Turbopack loader already call this function, so the Rollup plugin no longer needs its own fast-path setup. The fast path's source maps listed each annotated file by its base name only, which dropped the directory. That is the bug from #23561, which was fixed for the Babel path, and it would have come back for Webpack. The maps now keep the full path, so Rollup and Vite builds that use the fast path get full paths too. Ref #24415
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #24437.
When
reactComponentAnnotation._experimentalInjectIntoHtmlwas set, annotation always went through Babel, even on Vite 8. This PR ports that mode to the fast walker, so every Rollup and Vite build now uses the fast path. The next step moves Webpack and the Next.js Turbopack loader over, and after that Babel can be removed.HTML mode finds components the same way as the normal mode. The difference is in how it handles JSX. It adds only
data-sentry-component, and only to the first HTML elements below each component root, looking through fragments and component elements to find them. The port keeps two Babel quirks so the output stays the same: element names starting with_or$count as HTML elements, and anonymous classes getdata-sentry-component="".The new tests compare the walker with the Babel HTML plugin on both
@babel/parserandoxc-parseroutput.Ref #24415