perf(bundler-plugins): Use fast component annotation for Webpack and Turbopack - #24448
Merged
Merged
Conversation
timfish
added this pull request to stack #24441
September 16, 2026 17:07
timfish
marked this pull request as ready for review
September 16, 2026 17:14
timfish
requested review from
mydea and
s1gr1d
and removed request for
a team
September 16, 2026 17:14
Contributor
size-limit report 📦
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
timfish
force-pushed
the
feat/fast-annotation-webpack-turbopack
branch
from
September 17, 2026 09:26
1e153da to
56fb5d9
Compare
timfish
force-pushed
the
feat/fast-annotation-webpack-turbopack
branch
from
September 20, 2026 12:51
56fb5d9 to
053b721
Compare
Contributor
timfish
force-pushed
the
feat/fast-annotation-webpack-turbopack
branch
from
September 21, 2026 22:02
053b721 to
d9ab8d6
Compare
Contributor
|
👋 @chargome — Please review this PR when you get a chance! |
timfish
force-pushed
the
feat/fast-annotation-webpack-turbopack
branch
from
September 22, 2026 10:50
d9ab8d6 to
c7d168f
Compare
chargome
approved these changes
Sep 23, 2026
Base automatically changed from
feat/fast-annotation-html-injection
to
develop
September 23, 2026 10:23
timfish
force-pushed
the
feat/fast-annotation-webpack-turbopack
branch
from
September 23, 2026 10:23
c7d168f to
072d7c6
Compare
| export function createComponentNameAnnotateHooks( | ||
| ignoredComponents: string[], | ||
| injectIntoHtml: boolean, | ||
| getParseAstAsync?: () => Promise<ParseAstAsync | null>, |
Contributor
There was a problem hiding this comment.
Bug: The Rollup and Vite plugins lack error handling for the dynamic import('./component-annotation-oxc'). An import failure will cause an unhandled rejection, bypassing the intended Babel fallback.
Severity: MEDIUM
Suggested Fix
Wrap the await (await fastHooksPromise).transform(...) call within a try/catch block. In the catch block, implement the fallback to the Babel transformation. Alternatively, add a .catch() handler to the fastHooksPromise promise chain to gracefully handle potential import failures, similar to the existing implementation in the Turbopack loader.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/bundler-plugins/src/core/index.ts#L90
Potential issue: In the Rollup and Vite plugins, the `transform` function awaits
`fastHooksPromise`, which is derived from a dynamic
`import('./component-annotation-oxc')`. If this import fails due to build-time issues
like file corruption or resolution problems, the promise will reject. This rejection is
not handled by a `try/catch` block or a `.catch()` handler. As a result, the unhandled
rejection will propagate up, crashing the bundler's transform hook and bypassing the
intended fallback mechanism that uses Babel for transformation.
timfish
added a commit
that referenced
this pull request
Sep 23, 2026
…#24449) Stacked on #24448. Every bundler integration now annotates React components with the fast oxc-based path. This PR removes the Babel fallback from that path, so `@babel/core` is no longer a runtime dependency of `@sentry/bundler-plugins`. The `@sentry/bundler-plugins/babel-plugin` export stays, because the React Native SDK uses it with Metro. The plugin only imports Babel types and runs inside the user's own Babel. So `@babel/core` moves to `devDependencies` and becomes an optional peer dependency, and the export keeps working. Without the fallback, `oxc-parser` leaves a file it cannot parse unchanged, and the bundler reports the syntax error. If no parser can load, for example on a platform without an `oxc-parser` native binary, the plugin logs one warning and skips annotations. Fixes #24415
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #24440. Webpack and the Next.js Turbopack loader still annotated React components with Babel. This PR moves them to the fast oxc-based path, so every bundler integration now uses it. Babel stays as the fallback when
oxc-parsercannot load or cannot parse a file. The next PR in the stack removes that fallback.createComponentNameAnnotateHooksnow tries the fast path first and uses Babel only when the fast path does not handle the file. Webpack, the Rollup and Vite plugins, and the Turbopack loader already call this function, so the Rollup plugin no longer needs its own fast-path setup.The fast path's source maps listed each annotated file by its base name only, which dropped the directory. That is the bug from #23561, which was fixed for the Babel path, and it would have come back for Webpack. The maps now keep the full path, so Rollup and Vite builds that use the fast path get full paths too.
Ref #24415