Skip to content

chore: Update base node version to 24.21.0 #24343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JPeer264 merged 1 commit into from
Sep 28, 2026
Merged

chore: Update base node version to 24.21.0 #24343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/astro-5-cf-workers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
"wrangler": "^4.63.0"
},
"volta": {
"node": "24.15.0",
"extends": "../../package.json"
}
}
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/astro-6-cf-workers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
"wrangler": "^4.72.0"
},
"volta": {
"node": "24.15.0",
"extends": "../../package.json"
}
}
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/cloudflare-autoinstrument/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
"ws": "^8.21.1"
},
"volta": {
"node": "24.15.0",
"extends": "../../package.json"
}
}
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/cloudflare-local-workers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"ws": "^8.18.3"
},
"volta": {
"node": "24.15.0",
"extends": "../../package.json"
},
"pnpm": {
Expand Down
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/cloudflare-mcp-agent/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"wrangler": "^4.86.0"
},
"volta": {
"node": "24.15.0",
"extends": "../../package.json"
}
}
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/cloudflare-mcp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
"ws": "^8.18.3"
},
"volta": {
"node": "24.15.0",
"extends": "../../package.json"
}
}
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/cloudflare-orchestrion-mysql/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
"ws": "^8.18.3"
},
"volta": {
"node": "24.15.0",
"extends": "../../package.json"
}
}
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/cloudflare-vercelai-v7/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"ws": "^8.18.3"
},
"volta": {
"node": "24.15.0",
"extends": "../../package.json"
}
}
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/cloudflare-workers-static/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"ws": "^8.18.3"
},
"volta": {
"node": "24.15.0",
"extends": "../../package.json"
},
"pnpm": {
Expand Down
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/cloudflare-workers-workflow-legacy/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
"wrangler": "4.70.0"
},
"volta": {
"node": "24.15.0",
"extends": "../../package.json"
}
}
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/cloudflare-workers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"ws": "^8.18.3"
},
"volta": {
"node": "24.15.0",
"extends": "../../package.json"
},
"pnpm": {
Expand Down
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/cloudflare-workersentrypoint/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"ws": "^8.18.3"
},
"volta": {
"node": "24.15.0",
"extends": "../../package.json"
},
"pnpm": {
Expand Down
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/effect-4-browser/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
]
},
"volta": {
"node": "22.15.0",
"extends": "../../package.json"
}
}
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/effect-4-node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
"@sentry-internal/test-utils": "link:../../../test-utils"
},
"volta": {
"node": "22.15.0",
"extends": "../../package.json"
}
}
1 change: 1 addition & 0 deletions dev-packages/e2e-tests/test-applications/react-send-to-sentry/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
"serve": "14.0.1"
},
"volta": {
"node": "20.19.5",
"extends": "../../package.json"
},
"sentryTest": {
Expand Down
3 changes: 1 addition & 2 deletions dev-packages/e2e-tests/test-applications/solidstart-2/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@
"vitest": "^1.5.0"
},
"volta": {
"extends": "../../package.json",
"node": "24.15.0"
"extends": "../../package.json"
},
"engines": {
"node": ">=24"
Expand Down
1 change: 1 addition & 0 deletions dev-packages/e2e-tests/test-applications/solidstart-static/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
"vitest": "^3.2.7"
},
"volta": {
"node": "20.19.5",

@s1gr1d s1gr1d Sep 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe directly add an issue so we fix the solidstart test and can remove this pinned version

@JPeer264 JPeer264 Sep 28, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah on it. Didn't want to add issues before it got merged :D

@JPeer264 JPeer264 Sep 28, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1: #24786
2: #24787

"extends": "../../package.json"
}
}
1 change: 1 addition & 0 deletions dev-packages/e2e-tests/test-applications/solidstart/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
"vitest": "^3.2.7"
},
"volta": {
"node": "20.19.5",
"extends": "../../package.json"
}
}
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/sveltekit-cloudflare-pages/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
"wrangler": "^4.61.0"
},
"volta": {
"node": "24.15.0",
"extends": "../../package.json"
}
}
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/tanstackstart-react-cloudflare/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
"wrangler": "^4.68.1"
},
"volta": {
"node": "24.15.0",
"extends": "../../package.json"
},
"sentryTest": {
Expand Down
1 change: 1 addition & 0 deletions dev-packages/e2e-tests/test-applications/tsx-express/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"@types/qs": "6.9.17"
},
"volta": {
"node": "20.19.5",
"extends": "../../package.json"
}
}
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"yalc:publish": "nx run-many -t yalc:publish"
},
"volta": {
"node": "20.19.5",
"node": "24.21.0",
"yarn": "1.22.22",
Comment thread
JPeer264 marked this conversation as resolved.
"pnpm": "9.15.9"
},
Expand Down
12 changes: 6 additions & 6 deletions packages/browser/test/integrations/httpcontext.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,20 @@ const USER_AGENT =
'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.124 Safari/537.36';

describe('httpContextIntegration', () => {
globalThis.navigator = {
vi.stubGlobal('navigator', {
userAgent:
'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.124 Safari/537.36',
} as unknown as Navigator;
globalThis.location = {
} as unknown as Navigator);
vi.stubGlobal('location', {
href: 'https://example.com',
} as unknown as Location;
globalThis.document = {
} as unknown as Location);
vi.stubGlobal('document', {
referrer: 'https://example.com',
addEventListener: vi.fn(),
location: {
href: 'https://example.com',
},
} as unknown as Document;
} as unknown as Document);

it("doesn't attach url.full to http.client segment spans", () => {
const integration = httpContextIntegration();
Expand Down
17 changes: 17 additions & 0 deletions packages/react/test/reactrouter-cross-usage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,23 @@ import {
wrapUseRoutesV6,
} from '../src/reactrouterv6';

// jsdom provides its own AbortSignal, which the undici `Request` of Node >= 24 rejects
// in `RequestInit`. React Router only reads the signal back off the request, so keep it
// as an own property instead of handing it to undici.
const NativeRequest = globalThis.Request;
vi.stubGlobal(
'Request',
class extends NativeRequest {
public constructor(input: RequestInfo | URL, init: RequestInit = {}) {
const { signal, ...rest } = init;
super(input, rest);
if (signal) {
Object.defineProperty(this, 'signal', { value: signal, configurable: true });
}
}
},
);

const mockStartBrowserTracingPageLoadSpan = vi.fn();
const mockStartBrowserTracingNavigationSpan = vi.fn();

Expand Down
2 changes: 1 addition & 1 deletion packages/replay-internal/test/unit/util/addEvent.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ describe('Unit | util | addEvent', () => {
expect(recordDroppedEventSpy).not.toHaveBeenCalled();
});

it('stops when exceeding buffer size limit', async function () {
it('stops when exceeding buffer size limit', { timeout: 10_000 }, async function () {
vi.setSystemTime(BASE_TIMESTAMP);

const replay = setupReplayContainer({
Expand Down
Loading