Skip to content

chore: Update base node version to 24.21.0 - #24343

Merged
JPeer264 merged 1 commit into
developfrom
jp/update-local-node
Sep 28, 2026
Merged

JPeer264 merged 1 commit into
developfrom
jp/update-local-node

Conversation

@JPeer264

@JPeer264 JPeer264 commented Sep 11, 2026 •

Copy link
Copy Markdown
Member

(I recommend to merge this after we released v11, just to keep the first v11 release smooth in case this PR would cause any issues)

This updates our base local node version to 24.21.0.

There is only 1 benefit for Cloudflare. We can update wrangler (see: #24314)

Kept tests were it was explicitly set to v22. v24 pins were removed.

Some E2E tests were failing when upgrading to v24, so I downgraded the failing tests to v20 - these should be checked out individually (didn't want to change them here, to keep changes minimal).

@JPeer264 JPeer264 self-assigned this Sep 11, 2026
@JPeer264
JPeer264 force-pushed the jp/update-local-node branch from 628e143 to c67e9f0 Compare September 11, 2026 15:17
@github-actions

github-actions Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 29.24 kB - -
@sentry/browser - with treeshaking flags 27.5 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 27.4 kB - -
@sentry/browser (incl. Tracing) 51.15 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 51.17 kB - -
@sentry/browser (incl. Tracing, Profiling) 54.18 kB - -
@sentry/browser (incl. Tracing, Replay) 90.76 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 79.86 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 95.46 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 108.41 kB - -
@sentry/browser (incl. Feedback) 46.76 kB - -
@sentry/browser (incl. sendFeedback) 34.3 kB - -
@sentry/browser (incl. FeedbackAsync) 39.41 kB - -
@sentry/browser (incl. Metrics) 30.25 kB - -
@sentry/browser (incl. Logs) 30.51 kB - -
@sentry/browser (incl. Metrics & Logs) 31.18 kB - -
@sentry/react 31 kB - -
@sentry/react (incl. Tracing) 53.45 kB - -
@sentry/vue 36.74 kB - -
@sentry/vue (incl. Tracing) 53.7 kB - -
@sentry/svelte 29.26 kB - -
CDN Bundle 30.93 kB - -
CDN Bundle (incl. Tracing) 51.69 kB - -
CDN Bundle (incl. Logs, Metrics) 33.2 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 53.66 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 73.92 kB - -
CDN Bundle (incl. Tracing, Replay) 89.28 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 91.25 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 95.45 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 97.42 kB - -
CDN Bundle - uncompressed 91.4 kB - -
CDN Bundle (incl. Tracing) - uncompressed 153.77 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 97.97 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 159.73 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 227.54 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 273.5 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 279.44 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 287.2 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 293.13 kB - -
@sentry/nextjs (client) 55.77 kB - -
@sentry/sveltekit (client) 51.59 kB - -
@sentry/core/server 39.95 kB - -
@sentry/core/browser 13.63 kB - -
@sentry/node 137.13 kB +0.01% +10 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 82.8 kB - -
@sentry/node - without tracing 90.73 kB +0.02% +11 B 🔺
@sentry/node - without channel injection 115.5 kB +0.01% +10 B 🔺
@sentry/aws-serverless 99 kB +0.02% +10 B 🔺
@sentry/cloudflare (withSentry) - minified 206.62 kB - -
@sentry/cloudflare (withSentry) 514.02 kB - -

View base workflow run

@JPeer264
JPeer264 requested a review from a team as a code owner September 11, 2026 15:55
@JPeer264
JPeer264 marked this pull request as draft September 11, 2026 15:55
@JPeer264
JPeer264 removed request for a team, logaretm, mydea and s1gr1d September 11, 2026 15:55
@JPeer264

Copy link
Copy Markdown
Member Author

moved to draft as not all tests love that node version upgrade

@JPeer264
JPeer264 force-pushed the jp/update-local-node branch 2 times, most recently from c55ea35 to 34110b0 Compare September 22, 2026 19:22
@JPeer264
JPeer264 marked this pull request as ready for review September 23, 2026 04:57
@JPeer264
JPeer264 requested a review from a team as a code owner September 23, 2026 04:57
@JPeer264
JPeer264 requested review from logaretm, nicohrubec and s1gr1d and removed request for a team September 23, 2026 04:57
@JPeer264
JPeer264 force-pushed the jp/update-local-node branch from 34110b0 to 5bce80b Compare September 28, 2026 08:35
Comment thread package.json
"vitest": "^3.2.7"
},
"volta": {
"node": "20.19.5",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe directly add an issue so we fix the solidstart test and can remove this pinned version

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah on it. Didn't want to add issues before it got merged :D

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1: #24786
2: #24787

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@JPeer264
JPeer264 force-pushed the jp/update-local-node branch from 5bce80b to b92948d Compare September 28, 2026 09:18
@JPeer264
JPeer264 merged commit 600851e into develop Sep 28, 2026
661 of 666 checks passed
@JPeer264
JPeer264 deleted the jp/update-local-node branch September 28, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants