Skip to content

docs(js): use notSupportedCategories for feature-flag integrations #19500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mydea merged 1 commit into from
Sep 21, 2026
Merged

docs(js): use notSupportedCategories for feature-flag integrations #19500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions docs/platforms/javascript/common/configuration/integrations/launchdarkly.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,12 @@
---
title: LaunchDarkly
description: "Learn how to use Sentry with LaunchDarkly."
notSupportedCategories:
- server-only
Comment on lines +4 to +5

@sentry sentry Bot Sep 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The isSupported check relies on a server-only category in guide configs. Since server-only guides lack this category, integration pages will be incorrectly shown for them.
Severity: MEDIUM

Suggested Fix

Ensure that the guide configurations for all server-side JavaScript platforms (e.g., aws-lambda, bun, node) include categories: ['server-only']. This could be done by merging the dependent PR that adds these categories first, or by including those configuration changes in this PR to make it self-contained.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location:
docs/platforms/javascript/common/configuration/integrations/launchdarkly.mdx#L4-L5

Potential issue: The code replaces an explicit `notSupported` platform list with
`notSupportedCategories: ['server-only']`. However, the `isSupported` function's check,
`matchesCategory(frontmatter.notSupportedCategories)`, will return `false` for
server-only guides like `aws-lambda`. This is because their guide configurations do not
define the `server-only` category, causing `guideFrontmatter.categories` to be an empty
array. As a result, integration pages intended for client-side platforms will be
incorrectly displayed on documentation pages for server-only platforms. This issue is
contingent on this PR being merged before the one that adds the necessary category
definitions to guide configs.

Also affects:

  • docs/platforms/javascript/common/configuration/integrations/openfeature.mdx:4~5
  • docs/platforms/javascript/common/configuration/integrations/statsig.mdx:4~5
  • docs/platforms/javascript/common/configuration/integrations/unleash.mdx:4~5

Did we get this right? 👍 / 👎 to inform future reviews.

notSupported:
- javascript.aws-lambda
- javascript.azure-functions
- javascript.bun
- javascript.capacitor
- javascript.cloudflare
- javascript.connect
- javascript.cordova
- javascript.deno
- javascript.electron
- javascript.express
- javascript.fastify
- javascript.gcp-functions
- javascript.hapi
- javascript.hono
- javascript.koa
- javascript.nitro
- javascript.nestjs
- javascript.node
- javascript.eve
- javascript.mastra
- javascript.wasm
---

Expand Down
19 changes: 2 additions & 17 deletions docs/platforms/javascript/common/configuration/integrations/openfeature.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,12 @@
---
title: OpenFeature
description: "Learn how to use Sentry with OpenFeature."
notSupportedCategories:
- server-only
notSupported:
- javascript.aws-lambda
- javascript.azure-functions
- javascript.bun
- javascript.capacitor
- javascript.cloudflare
- javascript.connect
- javascript.cordova
- javascript.deno
- javascript.electron
- javascript.express
- javascript.fastify
- javascript.gcp-functions
- javascript.hapi
- javascript.hono
- javascript.koa
- javascript.nitro
- javascript.nestjs
- javascript.node
- javascript.eve
- javascript.mastra
- javascript.wasm
---

Expand Down
17 changes: 2 additions & 15 deletions docs/platforms/javascript/common/configuration/integrations/statsig.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,12 @@
---
title: Statsig
description: "Learn how to use Sentry with Statsig."
notSupportedCategories:
- server-only
notSupported:
- javascript.aws-lambda
- javascript.azure-functions
- javascript.bun
- javascript.capacitor
- javascript.cloudflare
- javascript.connect
- javascript.cordova
- javascript.deno
- javascript.electron

@chargome chargome Sep 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated but does this not work on electron? 🤔

@chargome chargome Sep 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quickly checked this should work on electron, we can fix this in a follow up

- javascript.express
- javascript.fastify
- javascript.gcp-functions
- javascript.hapi
- javascript.koa
- javascript.nestjs
- javascript.node
- javascript.eve
- javascript.mastra
- javascript.wasm
---

Expand Down
19 changes: 2 additions & 17 deletions docs/platforms/javascript/common/configuration/integrations/unleash.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,12 @@
---
title: Unleash
description: "Learn how to use Sentry with Unleash."
notSupportedCategories:
- server-only
notSupported:
- javascript.aws-lambda
- javascript.azure-functions
- javascript.bun
- javascript.capacitor
- javascript.cloudflare
- javascript.connect
- javascript.cordova
- javascript.deno
- javascript.electron
- javascript.express
- javascript.fastify
- javascript.gcp-functions
- javascript.hapi
- javascript.hono
- javascript.koa
- javascript.nitro
- javascript.nestjs
- javascript.node
- javascript.eve
- javascript.mastra
- javascript.wasm
---

Expand Down
Loading