Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
2b51f45 to
7396c62
Compare
| notSupportedCategories: | ||
| - server-only |
There was a problem hiding this comment.
Bug: The isSupported check relies on a server-only category in guide configs. Since server-only guides lack this category, integration pages will be incorrectly shown for them.
Severity: MEDIUM
Suggested Fix
Ensure that the guide configurations for all server-side JavaScript platforms (e.g., aws-lambda, bun, node) include categories: ['server-only']. This could be done by merging the dependent PR that adds these categories first, or by including those configuration changes in this PR to make it self-contained.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
docs/platforms/javascript/common/configuration/integrations/launchdarkly.mdx#L4-L5
Potential issue: The code replaces an explicit `notSupported` platform list with
`notSupportedCategories: ['server-only']`. However, the `isSupported` function's check,
`matchesCategory(frontmatter.notSupportedCategories)`, will return `false` for
server-only guides like `aws-lambda`. This is because their guide configurations do not
define the `server-only` category, causing `guideFrontmatter.categories` to be an empty
array. As a result, integration pages intended for client-side platforms will be
incorrectly displayed on documentation pages for server-only platforms. This issue is
contingent on this PR being merged before the one that adds the necessary category
definitions to guide configs.
Also affects:
docs/platforms/javascript/common/configuration/integrations/openfeature.mdx:4~5docs/platforms/javascript/common/configuration/integrations/statsig.mdx:4~5docs/platforms/javascript/common/configuration/integrations/unleash.mdx:4~5
Did we get this right? 👍 / 👎 to inform future reviews.
| - javascript.connect | ||
| - javascript.cordova | ||
| - javascript.deno | ||
| - javascript.electron |
There was a problem hiding this comment.
unrelated but does this not work on electron? 🤔
There was a problem hiding this comment.
quickly checked this should work on electron, we can fix this in a follow up
7396c62 to
efa1deb
Compare
efa1deb to
b2dac82
Compare
Replace the enumerated backend-framework `notSupported` lists on the feature flag integration pages (launchdarkly, openfeature, statsig, unleash) with `notSupportedCategories: [server-only]`, keeping the browser/desktop exclusions (capacitor/cordova/electron/wasm) as explicit keys. These SDK integrations ship in the browser bundle only, so they are excluded from server-only runtimes. The category form makes the four pages consistent: statsig previously omitted hono/nitro from its list (so it still rendered there), which this aligns with the other three. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
b2dac82 to
82bdd86
Compare
DESCRIBE YOUR PR
Convert the feature-flag integration pages (launchdarkly, openfeature, statsig, unleash) to
notSupportedCategories: [server-only], keeping browser/desktop exclusions explicit.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace
YYYY-MM-DDwith the due date. You can update this information later by editing the PR description.SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
🤖 Generated with Claude Code