Skip to content

docs(js): use notSupportedCategories for feature-flag integrations - #19500

Merged
mydea merged 1 commit into
guide-cat/08-browser-integrationsfrom
guide-cat/09-feature-flag-integrations
Sep 21, 2026
Merged

mydea merged 1 commit into
guide-cat/08-browser-integrationsfrom
guide-cat/09-feature-flag-integrations

Conversation

@mydea

@mydea mydea commented Sep 18, 2026 •

Copy link
Copy Markdown
Member

DESCRIBE YOUR PR

Stacked PR. Part of the JavaScript guide-categories series (#19492 → #19506). Depends on #19499; review/merge bottom-up.

Convert the feature-flag integration pages (launchdarkly, openfeature, statsig, unleash) to notSupportedCategories: [server-only], keeping browser/desktop exclusions explicit.

  • These integrations ship in the browser bundle only. The change also makes the four pages consistent (statsig previously omitted hono/nitro).

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace YYYY-MM-DD with the due date. You can update this information later by editing the PR description.

  • Urgent deadline (GA date, etc.): YYYY-MM-DD
  • Other deadline: YYYY-MM-DD
  • No deadline: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've supplied a deadline.

Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

🤖 Generated with Claude Code

@vercel

vercel Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sentry-docs Ready Ready Preview Sep 21, 2026 8:37am UTC
1 Skipped Deployment
Project Deployment Actions Updated
develop-docs Ignored Ignored Preview Sep 21, 2026 8:37am UTC

Request Review

@github-actions github-actions Bot added the Priority: Needs Triage The PR description is missing valid priority information label Sep 18, 2026
@mydea
mydea added this pull request to stack #19507 September 18, 2026 10:24
@github-actions github-actions Bot added Priority: Normal Docs review has no urgent deadline and removed Priority: Needs Triage The PR description is missing valid priority information labels Sep 18, 2026
@mydea
mydea force-pushed the guide-cat/09-feature-flag-integrations branch from 2b51f45 to 7396c62 Compare September 18, 2026 10:49
@mydea
mydea marked this pull request as ready for review September 18, 2026 10:50
@codeowner-assignment
codeowner-assignment Bot requested a review from a team September 18, 2026 10:50
Comment on lines +4 to +5
notSupportedCategories:
- server-only

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The isSupported check relies on a server-only category in guide configs. Since server-only guides lack this category, integration pages will be incorrectly shown for them.
Severity: MEDIUM

Suggested Fix

Ensure that the guide configurations for all server-side JavaScript platforms (e.g., aws-lambda, bun, node) include categories: ['server-only']. This could be done by merging the dependent PR that adds these categories first, or by including those configuration changes in this PR to make it self-contained.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location:
docs/platforms/javascript/common/configuration/integrations/launchdarkly.mdx#L4-L5

Potential issue: The code replaces an explicit `notSupported` platform list with
`notSupportedCategories: ['server-only']`. However, the `isSupported` function's check,
`matchesCategory(frontmatter.notSupportedCategories)`, will return `false` for
server-only guides like `aws-lambda`. This is because their guide configurations do not
define the `server-only` category, causing `guideFrontmatter.categories` to be an empty
array. As a result, integration pages intended for client-side platforms will be
incorrectly displayed on documentation pages for server-only platforms. This issue is
contingent on this PR being merged before the one that adds the necessary category
definitions to guide configs.

Also affects:

  • docs/platforms/javascript/common/configuration/integrations/openfeature.mdx:4~5
  • docs/platforms/javascript/common/configuration/integrations/statsig.mdx:4~5
  • docs/platforms/javascript/common/configuration/integrations/unleash.mdx:4~5

Did we get this right? 👍 / 👎 to inform future reviews.

- javascript.connect
- javascript.cordova
- javascript.deno
- javascript.electron

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated but does this not work on electron? 🤔

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quickly checked this should work on electron, we can fix this in a follow up

Replace the enumerated backend-framework `notSupported` lists on the feature
flag integration pages (launchdarkly, openfeature, statsig, unleash) with
`notSupportedCategories: [server-only]`, keeping the browser/desktop
exclusions (capacitor/cordova/electron/wasm) as explicit keys.

These SDK integrations ship in the browser bundle only, so they are excluded
from server-only runtimes. The category form makes the four pages consistent:
statsig previously omitted hono/nitro from its list (so it still rendered
there), which this aligns with the other three.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@mydea
mydea force-pushed the guide-cat/09-feature-flag-integrations branch from b2dac82 to 82bdd86 Compare September 21, 2026 08:30
@mydea
mydea merged commit 467246e into master Sep 21, 2026
24 of 35 checks passed
@mydea
mydea deleted the guide-cat/09-feature-flag-integrations branch September 21, 2026 09:04

This branch was successfully deployed

2 active (1 outdated) deployments
Preview – sentry-docs — 82bdd869 Deployed Sep 21, 2026 by vercel[bot]
Preview – develop-docs — 2b51f45e Deployed Sep 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Normal Docs review has no urgent deadline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants