Repository navigation
feat(storage): Make TCP user timeout configurable #682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -604,21 +604,33 @@ pub enum TieredUpdate { | |
| /// | ||
| /// Automatic decompression is disabled because backends store pre-compressed | ||
| /// payloads and manage `Content-Encoding` themselves. | ||
| pub(super) fn reqwest_client() -> reqwest::Client { | ||
| reqwest::Client::builder() | ||
| pub(super) fn reqwest_client(tcp_user_timeout: Duration) -> reqwest::Client { | ||
| let builder = reqwest::Client::builder() | ||
| .user_agent(USER_AGENT) | ||
| .hickory_dns(true) | ||
| .http1_only() | ||
| .no_zstd() | ||
| .no_brotli() | ||
| .no_gzip() | ||
| .no_deflate() | ||
| .no_deflate(); | ||
|
|
||
| #[cfg(target_os = "linux")] | ||
| let builder = builder.tcp_user_timeout(tcp_user_timeout); | ||
| #[cfg(not(target_os = "linux"))] | ||
| let _ = tcp_user_timeout; | ||
|
|
||
| builder | ||
| .build() | ||
| // INVARIANT: Building fails only if the TLS backend cannot be initialized, which | ||
| // is checked at startup when the rustls crypto provider is installed. | ||
| .expect("failed to build backend HTTP client") | ||
| } | ||
|
|
||
| /// Matches reqwest's default TCP user timeout on supported platforms. | ||
| pub(super) fn default_tcp_user_timeout() -> Duration { | ||
| Duration::from_secs(30) | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In a follow-up, we can consider to lower the timeout to 5-10s. |
||
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { | ||
| use super::*; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only linux? but what if we want to run objectstore on android!!!