Repository navigation
feat(storage): Make TCP user timeout configurable - #682
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #682 +/- ##
==========================================
+ Coverage 91.33% 91.35% +0.01%
==========================================
Files 117 117
Lines 24171 24185 +14
==========================================
+ Hits 22077 22093 +16
+ Misses 2094 2092 -2
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jan-auer
commented
Oct 12, 2026
|
|
||
| /// Matches reqwest's default TCP user timeout on supported platforms. | ||
| pub(super) fn default_tcp_user_timeout() -> Duration { | ||
| Duration::from_secs(30) |
Member
Author
There was a problem hiding this comment.
In a follow-up, we can consider to lower the timeout to 5-10s.
jan-auer
marked this pull request as ready for review
October 13, 2026 10:52
matt-codecov
approved these changes
Oct 13, 2026
Comment on lines
+617
to
+620
| #[cfg(target_os = "linux")] | ||
| let builder = builder.tcp_user_timeout(tcp_user_timeout); | ||
| #[cfg(not(target_os = "linux"))] | ||
| let _ = tcp_user_timeout; |
Contributor
There was a problem hiding this comment.
only linux? but what if we want to run objectstore on android!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose
tcp_user_timeouton GCS and S3-compatible backend configs, including tiered storage'slong_term, so operators can tune how long TCP writes may stall. Preserve the current30sdefault.The setting accepts human-readable durations through YAML or
OS__STORAGE__TCP_USER_TIMEOUT(OS__STORAGE__LONG_TERM__TCP_USER_TIMEOUTfor tiered storage). It is applied on Linux and ignored on other platforms. It detects stalled TCP writes, rather than limiting total upload duration or response time.Ref INC-2579