Repository navigation
fix(events): Tell the agent to write "you" to an Event doer outside People involved - #2623
Merged
Merged
Conversation
…eople involved A requester who reviewed their own pull request got a watch reply that mentioned them and then named their GitHub login as a second person. The review events have no People involved, so the doer line never said to write "you" or to drop the handle. Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BYK
approved these changes
Nov 3, 2026
BYK
enabled auto-merge (squash)
November 3, 2026 16:45
BYK
added a commit
that referenced
this pull request
Nov 4, 2026
Follow-up to #2623. Linked identities already resolve a GitHub login and a Slack user to one person. The task input still showed that person in up to three places: the People involved list, a separate Done by line with the same mention, and the handle the Event data uses. The agent then matched them up by hand, and sometimes wrote "@person BYK requested changes". Each linked person now appears once: ``` People involved: <@u123> (did what this Event describes; called "BYK" in the Event data), <@U456> If you mention <@u123>, write to them as "you", and do not also call them "BYK". ``` A doer outside People involved gets `Done by: <@u123> (…)` instead. A batch lists each doer once per Watch, with the Events they did (`did Event 1`), so the Events themselves no longer have Done by lines. Stored Event facts and the plugin contract are unchanged. Only the rendering changes. Adds a behavioral eval in `evals/coding/subscriptions.eval.ts`: the Slack person who asked reviews the PR from a linked GitHub login, and the reply must treat them as the reviewer and must not name the login. The eval fixture gains `insertLinkedGitHubIdentity`. <!-- junior-request-attribution:start --> via @BYK. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:local%3Aweb%3A7e24d58bb1265f0d1dbcdff7 --> -- [View Session in Sentry](https://sentry.sentry.io/explore/conversations/local%3Aweb%3A7e24d58bb1265f0d1dbcdff7/?project=4510944073809921) <!-- junior-session-footer:end --> Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: BYK <126780+BYK@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A requester reviewed their own Junior pull request (getsentry/craft#957). The watch reply mentioned them and then named their GitHub login as a second person: "@burak Yigit Kaya BYK requested changes on …".
The doer resolved to the right Slack user, so identity linking works. The gap is in the doer line of the task input. It says "write to them as you, and do not also call them " only when the doer is also in People involved. The webhook adds People involved only to approval and merge events. For
changes_requestedandcommentedreviews, the agent got "That is the same person" with no rule against the double naming. The junior-prod watch intent then asks it to mention the requester and to name the reviewer, so it did both.The fix adds the rule for a doer outside People involved: "If you mention them, write to them as "you", and do not also call them ""." The People involved wording does not change.
via @BYK.
--
View Session in Sentry