Repository navigation
fix(events): Render each linked Event person once - #2624
Merged
Merged
Conversation
An Event doer who is also in People involved appeared twice in the task input: once in People involved and again on a Done by line. The handle that the Event data uses for them was on a third line. The agent could then mention the person and name them again by handle. The doer now gets a note on their People involved entry, or a Done by line when they are not involved. Batches list doers once per Watch with the Event numbers they did. Add a behavioral eval for a requester who reviews their own pull request. Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BYK
approved these changes
Nov 4, 2026
BYK
enabled auto-merge (squash)
November 4, 2026 09:30
Contributor
|
7 screenshot changes — 7 changed · 0 added · 0 removed Review screenshots in Frameshift
Show 1 more changed screenshot
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2623.
Linked identities already resolve a GitHub login and a Slack user to one person. The task input still showed that person in up to three places: the People involved list, a separate Done by line with the same mention, and the handle the Event data uses. The agent then matched them up by hand, and sometimes wrote "@person BYK requested changes".
Each linked person now appears once:
A doer outside People involved gets
Done by: <@U123> (…)instead. A batch lists each doer once per Watch, with the Events they did (did Event 1), so the Events themselves no longer have Done by lines. Stored Event facts and the plugin contract are unchanged. Only the rendering changes.Adds a behavioral eval in
evals/coding/subscriptions.eval.ts: the Slack person who asked reviews the PR from a linked GitHub login, and the reply must treat them as the reviewer and must not name the login. The eval fixture gainsinsertLinkedGitHubIdentity.via @BYK.
--
View Session in Sentry