Skip to content

fix(error-reporting): Silence ValidationError in telemetry #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sentry wants to merge 2 commits into from
+11 −1
Closed

fix(error-reporting): Silence ValidationError in telemetry #1233

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea58049
fix(error-reporting): Silence ValidationError in telemetry
sentry[bot] Jul 13, 2026
cb23b91
fix(error-reporting): silence positional argument ValidationErrors
sentry[bot] Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/lib/error-reporting.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ type SilenceReason =
| "auth_expected"
| "api_user_error"
| "api_query_error"
| "network_error";
| "network_error"
| "validation_error";

/**
* Classify whether an error should be silenced.
Expand Down Expand Up @@ -82,6 +83,15 @@ export function classifySilenced(error: unknown): SilenceReason | null {
if (error instanceof ContextError) {
return "context_missing";
}
// A ValidationError with field "positional" means the user passed the wrong
// number of positional arguments — a user invocation mistake, never a CLI
// bug. Silence only this sub-case; other ValidationError fields (e.g.
// "installUrl" from buildFormatFromUrl) may reflect API-contract issues
// worth capturing. The `cli.error.silenced` metric preserves the volume.
// (CLI-1AN)
if (error instanceof ValidationError && error.field === "positional") {
return "validation_error";
}
Comment thread
sentry[bot] marked this conversation as resolved.
// All AuthError reasons are expected auth states the user must act on, not
// CLI bugs: `not_authenticated` (no token), `expired` (token aged out), and
// `invalid` (a bad/insufficiently-scoped token the user supplied). `invalid`
Expand Down
Loading