fix(error-reporting): Silence ValidationError in telemetry - #1233
Closed
sentry[bot] wants to merge 2 commits into
Closed
sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
Contributor
|
Member
|
we're not silencing using errors. |
Member
|
we're not silencing using errors. |
1 similar comment
Member
|
we're not silencing using errors. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ea58049. Configure here.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
ValidationErrorinstances, specifically those indicating "Too many positional arguments," were being reported to Sentry. These errors are a result of user input mistakes, not CLI bugs, and should therefore be silenced.The initial fix broadly silenced all
ValidationErrorinstances. However, upon review, it was noted thatValidationErroris also used for internal validation (e.g.,buildFormatFromUrlthrows it for unsupported build formats, setting thefieldto"installUrl"). Silencing allValidationErrors would hide potential genuine CLI or API-contract bugs.This PR refines the fix by narrowing the silencing condition in
classifySilenced()to onlyValidationErrorinstances where thefieldproperty is explicitly"positional". This ensures that only user-input errors related to positional arguments are silenced, while otherValidationErrors that might indicate deeper issues are still captured and reported to Sentry.Fixes CLI-1AN
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.