Skip to content

Accept a recursive Array wrapper in the Array own-key helpers - #8

Open
puskuruk wants to merge 1 commit into
mainfrom
fix/array-keys-over-recursive-wrapper
Open

puskuruk wants to merge 1 commit into
mainfrom
fix/array-keys-over-recursive-wrapper

Conversation

@puskuruk

@puskuruk puskuruk commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Object.keys over a value typed as a recursive dictionary-or-array union refused to lower. The Array own-key helpers now accept the recursive wrapper.

  • 9779f8e Accept a recursive Array wrapper in the Array own-key helpers (gate: gained object-keys-over-recursive-dictionary-or-array-union, 0 moved)

Verification: npm run build passed, npm run gate -- --write exit 0, node scripts/run-runtime-tests.mjs --only object-keys-over-recursive 1 ok, prettier clean.

Related

Independent of the other three compiler fixes (#7, #9, #10); all four go into compiler release 1.0.38, which node-compat geastack/node-compat#8 (compile hello-nest ahead of time) needs.

…gained object-keys-over-recursive-dictionary-or-array-union, 0 moved)
@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 51ed88a6-bbe4-4c75-8967-dfbc310dca8b
📥 Commits

Reviewing files that changed from the base of the PR and between d56bfb5 and 9779f8e.

📒 Files selected for processing: 3
  • scripts/emitted-baseline-runtime.txt
  • src/targets/cpp/runtime/gea_runtime.h
  • test/runtime/object-keys-over-recursive-dictionary-or-array-union.runtime.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant