Throw a catchable URIError from decodeURI and decodeURIComponent

[puskuruk]

A malformed escape in decodeURI/decodeURIComponent aborted the process. It now throws a catchable URIError, which Nest's router relies on for /%FF. The string-literal overload is taken by const char* ahead of the bool overload so the message is not coerced.

• bd72d5b Throw a catchable URIError from decodeURI and decodeURIComponent instead of aborting, and take a string literal by const char* ahead of the bool overload (gate: gained decode-uri-component-malformed-throws-uri-error, 0 moved)

Verification: npm run build passed, npm run gate -- --write exit 0, node scripts/run-runtime-tests.mjs --only decode-uri-component-malformed-throws-uri-error 1 ok, prettier clean.

Related

Independent of the other three compiler fixes (#7, #8, #9); all four go into compiler release 1.0.38, which node-compat geastack/node-compat#8 (compile hello-nest ahead of time) needs.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: b861e127-6f93-415e-8bf4-2a1e56b64ea5

📥 Commits

Reviewing files that changed from the base of the PR and between d56bfb5 and bd72d5b.

📒 Files selected for processing: 3

• scripts/emitted-baseline-runtime.txt
• src/targets/cpp/runtime/gea_runtime.h
• test/runtime/decode-uri-component-malformed-throws-uri-error.runtime.ts

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[puskuruk]

@coderabbitai review

[coderabbitai]

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.