Repository navigation
Fix the CI - #12
Merged
Merged
Fix the CI#12
Conversation
The checkout of GAP is made by Windows git, and Cygwin fails to copy
the ACLs of its directories ("preserving permissions ... Permission
denied"), which aborts the build. The installer does not store
permissions, so there is nothing to preserve.
Assisted-by: Generative AI
gap.iss defined OutputDir but never used it, so ISCC wrote to gap-windows/Output while the workflow uploaded Output/* from the workspace root and silently found nothing. Write to dist instead, which release_gap.sh creates, and fail the upload if it is empty. Assisted-by: Generative AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs kept CI from producing an installer:
cp -rpinto the runtime env failed on the 351 directories of the GAP checkout made by Windows git: Cygwin cannot copy their ACLs. The installer stores no permissions, so copy without-p.gap.issdefinedOutputDirbut never used it, so ISCC wrote togap-windows/Outputwhile the workflow uploadedOutput/*from the workspace root and found nothing. Write todistand fail the upload if it is empty.With both, the full run passes in 54 min and uploads a 774 MB installer: https://github.com/gap-system/gap-windows/actions/runs/39170868792
Fixes #5
🤖 Generated with Claude Code