Repository navigation
Write the installer to Output/ again - #15
Merged
Merged
Conversation
gap-system/gap's release workflow checks out gap-windows main and reads the installer from gap-windows/Output/, so writing it to dist/ broke its Windows job. Its stable-* branches carry the same workflow, so keep the path rather than change every copy of it. Assisted-by: Generative AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#12 moved the installer from
Output/todist/. gap-system/gap'srelease.ymlchecks out gap-windowsmainand readsgap-windows/Output/gap-*.exe, so its Windows job has failed since then, e.g. https://github.com/gap-system/gap/actions/runs/39366065495:stable-4.14,stable-4.15andstable-4.16carry the same path, so restoreOutput/here rather than change every copy.🤖 Generated with Claude Code