Add useInheritedMediaQuery removal breaking change entry and migration guide - #13916
Conversation
|
Staged preview of the updated docs.flutter.dev site (updated for commit 7d02638): https://flutter-docs-prod--docs-pr13916-remove-deprecated-usei-6n8ui4u8.web.app |
AbdeMohlbi
changed the title
useInheritedMediaQueryuseInheritedMediaQuery removal breaking change entry and migration guide
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request documents the removal of the useInheritedMediaQuery property from the Flutter framework by adding a new breaking change page and updating the breaking changes index. The review feedback focuses on improving the documentation's clarity and style-guide compliance, specifically by using code font for API names and classes, applying the Oxford comma, correcting grammatical errors, and updating the API documentation links for MaterialApp and CupertinoApp to point to the core Flutter API reference instead of pub.dev.
…ritedMediaQuery.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ritedMediaQuery.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ritedMediaQuery.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Hi, @AbdeMohlbi! Sorry to hear that you only tolerate Dart. ;) I asked @justinmc and he tells me that this property probably should be deprecated, but it hasn't been. Other than the bot's comment about referencing Material and Cupertino from the core API (which is wrong), I agree with the other bot feedback. I've asked Justin to weigh in on this PR. |
|
Staged preview of the updated flutter.dev site (updated for commit dc26d36): https://flutter-dev-230821--www-pr13916-remove-deprecated-usei-e25ajkps.web.app |
Yeah long story i have some bad history with dart, but things are getting better :-P No issue hopefully justin can review this one before the 3.50 cut. Thanks for the quick review @sfshaza2 ! |
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍 . We should probably include a dart fix as mentioned in a comment below. Otherwise, this parameter has been deprecated for over 3 years, so I think this clean up makes a lot of sense. Thank you for doing it! Is there any reason you want to remove it, or just cleanup?
| :::important | ||
| This migration isn't supported by `dart fix`. | ||
| ::: |
There was a problem hiding this comment.
I think it could be by using removeParameter right? What do you think about including a dart fix for this?
There was a problem hiding this comment.
not sure how create/edit dart fixes tbh
| Landed in version: TBD<br> | ||
| In stable release: TBD |
There was a problem hiding this comment.
Don't forget these when ready.
There was a problem hiding this comment.
you mean when the new stable is cut right ?
Not sure how to create new dart fixes, any guidance on that ? Well yes it's mostly cleanup, the framework has a lot of tech debt |
|
I'm going to land this. Thx, @AbdeMohlbi, tolerator of Dart! ;) |
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
lgtm. Dart fix isn't a website issue, so I leave that to the collective eng folk...
well that's the problem if we decided to create a dart fix we should update this document, still we can fix it later i guess. |
hmmm, so we are going to ignore the go (golang) part, i love go at this point so some updates can be made :-P |
|
@AbdeMohlbi Here is an example of a similar dart fix: https://github.com/flutter/flutter/blob/master/packages/flutter_test/lib/fix_data/fix_flutter_test/fix_animation_sheet_builder.yaml |
4 participants
This change adds
useInheritedMediaQueryremoval breaking change entry and migration guide.unblocks :
useInheritedMediaQueryflag inCupertinoApppackages#12970useInheritedMediaQuerypackages#12969useInheritedMediaQueryflutter#193146PRs or commits this PR depends on (if any):
Presubmit checklist
of 80 characters or fewer.