[material_ui] Remove deprecated useInheritedMediaQuery - #12969
Open
AbdeMohlbi wants to merge 2 commits into
Open
AbdeMohlbi wants to merge 2 commits into
AbdeMohlbi wants to merge 2 commits into
Conversation
github-actions
Bot
added
p: material_ui
triage-design
AbdeMohlbi
changed the title
useInheritedMediaQuery
AbdeMohlbi
changed the title
useInheritedMediaQueryuseInheritedMediaQuery
This was referenced Sep 22, 2026
sfshaza2
pushed a commit
to flutter/website
that referenced
this pull request
Sep 24, 2026
…ion guide (#13916) This change adds `useInheritedMediaQuery` removal breaking change entry and migration guide. unblocks : - flutter/packages#12970 - flutter/packages#12969 - flutter/flutter#193146 _PRs or commits this PR depends on (if any):_ ## Presubmit checklist - [x] If you are unwilling, or unable, to sign the CLA, even for a _tiny_, one-word PR, please file an issue instead of a PR. - [x] If this PR is not meant to land until a future stable release, mark it as draft with an explanation. - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style)—for example, it doesn't use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first-person pronouns). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
AbdeMohlbi
marked this pull request as ready for review
September 24, 2026 18:07
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the deprecated useInheritedMediaQuery parameter and property from MaterialApp, along with its associated tests. The review feedback suggests updating the pending changelog version bump from minor to major because removing a deprecated public parameter is a breaking change.
| @@ -0,0 +1,3 @@ | |||
| changelog: | | |||
| - Remove deprecated `useInheritedMediaQuery` flag in MaterialApp | |||
| version: minor | |||
Contributor
There was a problem hiding this comment.
Removing a deprecated public parameter (useInheritedMediaQuery) is a breaking change. If the package version is 1.0.0 or higher, this requires a major version bump instead of minor according to semantic versioning. Please verify the current package version and update this to major if the package is already at or past 1.0.0.
version: major
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blocked on:
useInheritedMediaQueryremoval breaking change entry and migration guide website#13916Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2