Skip to content

[google_maps_flutter_web] Add onPointOfInterestTap support - #12881

Closed
tenninebt wants to merge 1 commit into
flutter:mainfrom
tenninebt:google-maps-poi-web
Closed

tenninebt wants to merge 1 commit into
flutter:mainfrom
tenninebt:google-maps-poi-web

Conversation

@tenninebt

@tenninebt tenninebt commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

This is the web implementation portion of #11872

Depends on the published google_maps_flutter_platform_interface 2.17.0 from #12752

Reads placeId from map click events via a local JS interop extension (no dart:js_interop_unsafe) and emits PointOfInterestTapEvent.

Part of flutter/flutter#60695

Pre-Review Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the AI contribution guidelines and understand my responsibilities, or I am not using AI tools.
  • I read the Tree Hygiene page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter.
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I linked to at least one issue that this PR fixes in the description above.
  • I followed the version and CHANGELOG instructions, using semantic versioning and the repository CHANGELOG style.
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making.
  • All existing and new tests are passing.

web follow-up from #11872.

Detect placeId on map click events via a local JS interop extension
and emit PointOfInterestTapEvent for the new platform interface stream.
@tenninebt

Copy link
Copy Markdown
Contributor Author

Superseded by #12880 (consolidated Android/iOS/web implementations PR).

@tenninebt tenninebt closed this Sep 18, 2026
auto-submit Bot pushed a commit that referenced this pull request Sep 24, 2026
…ns (#12880)

## Summary

- Platform implementations of `onPointOfInterestTap` for **Android**, **iOS** (`sdk9` / `sdk10` + shared source), and **web**
- Depends on published `google_maps_flutter_platform_interface` 2.17.0 from #12752
- Federated implementations PR (per [Changing federated plugins](https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changing-federated-plugins)); app-facing package will follow in a separate PR

**Notes**
- Frozen `google_maps_flutter_ios` is intentionally unchanged (no new features per that package’s README); iOS support is in `google_maps_flutter_ios_sdk9` / `google_maps_flutter_ios_sdk10`
- iOS DI follows the Swift controller conventions (required `callbackHandler` on the designated initializer)

Supersedes the separate drafts #12881 (web) and #12882 (iOS).

Part of #11872 / flutter/flutter#60695.

## Pre-Review Checklist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants