[google_maps_flutter] Add onPointOfInterestTap platform implementations

[tenninebt]

Summary

• Platform implementations of onPointOfInterestTap for Android, iOS (sdk9 / sdk10 + shared source), and web
• Depends on published google_maps_flutter_platform_interface 2.17.0 from [google_maps_flutter_platform_interface] Add onPointOfInterestTap support #12752
• Federated implementations PR (per Changing federated plugins); app-facing package will follow in a separate PR

Notes

• Frozen google_maps_flutter_ios is intentionally unchanged (no new features per that package’s README); iOS support is in google_maps_flutter_ios_sdk9 / google_maps_flutter_ios_sdk10
• iOS DI follows the Swift controller conventions (required callbackHandler on the designated initializer)

Supersedes the separate drafts #12881 (web) and #12882 (iOS).

Part of #11872 / flutter/flutter#60695.

Pre-Review Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the AI contribution guidelines and understand my responsibilities, or I am not using AI tools.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter.
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I followed the version and CHANGELOG instructions, using semantic versioning and the repository CHANGELOG style.
• I updated/added any relevant documentation (doc comments with ///).
• I added new tests to check the change I am making.
• All existing and new tests are passing.

[gemini-code-assist]

Code Review

This pull request adds support for tapping points of interest (POI) on the map in the google_maps_flutter_android plugin. The changes include updating the Android implementation to handle POI clicks, adding the necessary Pigeon messaging definitions, and updating the platform interface and tests to support the new event. A review comment suggests adding a null check for the PointOfInterest object in the GoogleMapController to improve robustness.

[gemini-code-assist]

To prevent potential NullPointerExceptions, it is safer to perform a null check on pointOfInterest before accessing its properties, especially since it is a parameter received from an external SDK and Java does not have compile-time null safety.

Suggested change

	@Override
	public void onPoiClick(PointOfInterest pointOfInterest) {
	if (pointOfInterest.placeId != null) {
	flutterApi.onPointOfInterestTap(
	pointOfInterest.placeId, (Result<Unit> result) -> Unit.INSTANCE);
	}
	}
	@Override
	public void onPoiClick(PointOfInterest pointOfInterest) {
	if (pointOfInterest != null && pointOfInterest.placeId != null) {
	flutterApi.onPointOfInterestTap(
	pointOfInterest.placeId, (Result<Unit> result) -> Unit.INSTANCE);
	}
	}

[stuartmorgan-g]

Please do not put GitHub username references in PR descriptions; that becomes the commit message, and it causes a huge amount of spam for those users over time as people update forks that include the commit.

Also, pinging individual people is not how reviews are assigned. We have a triage process.

[tenninebt]

Please do not put GitHub username references in PR descriptions; that becomes the commit message, and it causes a huge amount of spam for those users over time as people update forks that include the commit.

Also, pinging individual people is not how reviews are assigned. We have a triage process.

Yeah you're right, won't happen again.

[gemini-code-assist]

Code Review

This pull request adds support for tapping points of interest (POIs) on the map across the Android, iOS, and Web implementations of the google_maps_flutter plugin. It introduces POI tap event handling, updates the platform interface, generates Pigeon messaging bindings, and adds corresponding unit and integration tests. Feedback on the changes suggests defensively checking for a null PointOfInterest parameter in the Android onPoiClick method to prevent a potential NullPointerException, along with adding a unit test to verify this behavior.

[gemini-code-assist]

To prevent a potential NullPointerException, we should defensively check if pointOfInterest is null before accessing its properties.

Suggested change

	@Override
	public void onPoiClick(PointOfInterest pointOfInterest) {
	if (pointOfInterest.placeId != null) {
	flutterApi.onPointOfInterestTap(
	pointOfInterest.placeId, (Result<Unit> result) -> Unit.INSTANCE);
	}
	}
	@Override
	public void onPoiClick(PointOfInterest pointOfInterest) {
	if (pointOfInterest != null && pointOfInterest.placeId != null) {
	flutterApi.onPointOfInterestTap(
	pointOfInterest.placeId, (Result<Unit> result) -> Unit.INSTANCE);
	}
	}

[gemini-code-assist]

Add a unit test to verify that onPoiClick safely handles a null PointOfInterest parameter without throwing a NullPointerException.

  @Test
  public void OnPoiClickNullPlaceIdDoesNotCallFlutterApi() {
    GoogleMapController googleMapController = getGoogleMapControllerWithMockedDependencies();
    googleMapController.onMapReady(mockGoogleMap);

    googleMapController.onPoiClick(new PointOfInterest(new LatLng(0, 0), null, "Test Place"));

    verify(flutterApi, times(0)).onPointOfInterestTap(any(), any());
  }

  @Test
  public void OnPoiClickNullPoiDoesNotCallFlutterApi() {
    GoogleMapController googleMapController = getGoogleMapControllerWithMockedDependencies();
    googleMapController.onMapReady(mockGoogleMap);

    googleMapController.onPoiClick(null);

    verify(flutterApi, times(0)).onPointOfInterestTap(any(), any());
  }

[mdebbar]

Web changes look good to me!

[camsim99]

Android LGTM

[flutter-dashboard]

This pull request is not mergeable in its current state, likely because of a merge conflict. Pre-submit CI jobs were not triggered. Pushing a new commit to this branch that resolves the issue will result in pre-submit jobs being scheduled.

[stuartmorgan-g]

The tile provider needs to be a parameter to this init method now, not something that relies on callers passing a specific implementation type.

[tenninebt]

Done — tileProvider is now its own init parameter. Convenience inits create one MapsCallbackApi and pass it for both that and callbackHandler.

[stuartmorgan-g]

We should never be making a second instance of the API handlers that's only partially used; that would make understanding call flows extremely confusing.

Also, this won't actually do anything. The tile provider is weakly owned by the overlay controller, so this is deallocated essentially immediately.

[tenninebt]

Yeah, that fallback was wrong on both counts. Removed it — no second handler instance anymore.

[stuartmorgan-g]

I cannot review code that is failing the CLA check. If you are the author of the code you pushed, you need to amend your commit to list yourself, using the email address you signed the CLA with, as the author, and then force-push.

[stuartmorgan-g]

iOS LGTM