Repository navigation
ci: ignore material.dart deprecation per import - #1062
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds TODO comments and deprecation ignore annotations to Flutter material imports across multiple files to prepare for a migration to material_ui. However, the added '// ignore: deprecated_member_use' comments are unnecessary and ineffective because importing material.dart does not trigger deprecation warnings, and line-level ignores in Dart only apply to the line immediately following them. It is recommended to remove these redundant ignore comments or use file-level ignores if deprecated members are actually used elsewhere in the files.
ditman
left a comment
There was a problem hiding this comment.
Thanks for addressing this so quickly, if CI is happy, I'm happy too!
|
I just realized that we need this too in the a2ui repo. I'll send a similar PR! |
Follow-up to #1058, as suggested in #1058 (comment).
#1058 made infos non-fatal on beta so that the
package:flutter/material.dartdeprecation wouldn't fail analysis. That turns off every other info on beta too, and it would have to be extended to stable once the deprecation ships there.This restores
flutter analyze --fatal-infoson both channels and instead ignoresdeprecated_member_useon eachimport 'package:flutter/material.dart';(85 imports acrosspackages/genui,examples/simple_chat,examples/verdure/client,dev_tools/catalog_galleryanddev_tools/composer):Migrating to
package:material_uistill isn't an option, since it requires Flutter 3.47 and genui supports 3.35.7. The cleanup is tracked in a2ui-project/a2ui#3235.