Repository navigation
ci(flutter): ignore material.dart deprecation in beta - #3249
Merged
ditman merged 2 commits intoOct 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds '// ignore: deprecated_member_use' comments before importing 'package:flutter/material.dart' across numerous files in the 'a2ui_flutter' package and sample applications, referencing issue #3235. I have no feedback to provide as there are no review comments.
ditman
commented
Oct 16, 2026
ditman
force-pushed
the
fix/ignore-material-deprecation
branch
from
October 16, 2026 01:09
06f89f6 to
e7751fa
Compare
Collaborator
Author
|
CI seems to not be running on "beta" on pull requests, so I updated my local copy of flutter to the latest $ flutter --version
Flutter 3.50.0-1.0.pre-78 • channel master • git@github.com:ditman/flutter-flutter.git
Framework • revision f7614d2898 (68 minutes ago) • 2026-10-16 00:10:16 +0000
Engine • hash 1fef39f7f7e0f3db1d0d09f761e6873b69fb9729 (revision dec795bfcc) (2 hours ago) • 2026-10-15 22:57:53.000Z
Tools • Dart 3.15.0 (build 3.15.0-34.0.dev) • DevTools 2.61.0
$ (cd dart/a2ui_flutter && flutter pub get && flutter analyze --fatal-infos) && (cd samples/client/flutter/restaurant_finder/app && flutter pub get && flutter analyze --fatal-infos)
Resolving dependencies in `/work/google/a2ui`...
Downloading packages...
_fe_analyzer_shared 103.0.0 (109.0.0 available)
...
yaml 3.1.3 (3.1.4 available)
Got dependencies in `/work/google/a2ui`!
41 packages have newer versions incompatible with dependency constraints.
Try `flutter pub outdated` for more information.
Analyzing a2ui_flutter...
No issues found! (ran in 6.9s)
Resolving dependencies in `/work/google/a2ui`...
Downloading packages...
_fe_analyzer_shared 103.0.0 (109.0.0 available)
...
yaml 3.1.3 (3.1.4 available)
Got dependencies in `/work/google/a2ui`!
41 packages have newer versions incompatible with dependency constraints.
Try `flutter pub outdated` for more information.
Analyzing app...
No issues found! (ran in 6.2s)(Seems like it'll work) |
ditman
marked this pull request as ready for review
October 16, 2026 01:21
ditman
enabled auto-merge (squash)
October 16, 2026 01:21
Collaborator
Author
|
(Auto-merge enabled) |
andrewkolos
approved these changes
Oct 16, 2026
andrewkolos
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for taking the initiative here 👍
Collaborator
Author
|
Thanks for reviewing after hours @andrewkolos! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Suppresses the
deprecated_member_useanalyzer warning onpackage:flutter/material.dartimports acrossdart/a2ui_flutterandsamples/client/flutter/restaurant_finder/app.Context
A recent Flutter
betachannel update markspackage:flutter/material.dartas deprecated (in preparation for the upcoming standalonepackage:material_uimigration). Because our Flutter CI workflow runsflutter analyze --fatal-infosagainst bothstableandbetaonmain, thedart_a2ui_flutter (beta)andsamples_client_flutter_restaurant_finder_app (beta)jobs are currently failing.Since the replacement package is not yet available on
stable, we cannot migrate the imports yet without breaking stable builds. Following the same approach taken influtter/genui#1062, this PR adds an inline analyzer ignore comment pointing to the tracking issue (#3235) above eachpackage:flutter/material.dartimport so we can keep--fatal-infosenabled on both channels.Changes
// ignore: deprecated_member_use, see https://github.com/a2ui-project/a2ui/issues/3235aboveimport 'package:flutter/material.dart';in:dart/a2ui_flutter(lib/andtest/— 43 files)samples/client/flutter/restaurant_finder/app(lib/— 3 files)Related to #3235.
Similar to flutter/genui#1058