Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/multi_version_tasks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
# TODO(stuartmorgan): Add a Dart version of --skip-if-not-supporting-flutter-version
# and pass that for non-'main'
matrix:
dart-sdk: [ 3.11.5, 3.12.0, main ]
dart-sdk: [ 3.12.2, 3.13.7, 3.14.0, main ]
fail-fast: false # Continues other versions even if one fails

runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
id: setup
uses: ./.github/actions/set-up-repo
with:
dart-sdk: 3.12.0
dart-sdk: 3.14.0

# Give some time for checks to start becoming populated.
# Because of latency in Github Webhooks, any checks that don't use GitHub
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/windows_unit_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- name: Set up environment and tooling
uses: ./.github/actions/set-up-repo
with:
dart-sdk: 3.12.0
dart-sdk: 3.14.0

- name: Run Dart unit tests
run: |
Expand Down
4 changes: 2 additions & 2 deletions .repo_tool_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ repo_name: flutter/core-packages
# The major and minor version here should match the lowest version analyzed
# in legacy version analysis.
# TODO(stuartmorgan): Set up legacy analysis in this repo. For now this matches
# the N-2 used in flutter/packages, but we aren't actually testing N-1 or N-2.
min_dart: '3.10.0'
# the N-2 used in flutter/packages.
min_dart: '3.12.0'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment on lines 12-13 states that 'we aren't actually testing N-1 or N-2'. Since this PR updates the test matrix to include N-2, this comment is now outdated and should be updated or removed to reflect the new testing setup.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the last half sentence.

@loic-sharma loic-sharma Nov 12, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the TODO comment entirely? Feel free to punt this to a follow-up PR if that makes things easier.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it for now, since legacy analysis still isn't set up in this repo. To handle it in a follow-up, we can move N-1/N-2 in multi_version_tasks.yaml to a legacy analysis job like flutter/packages has (remove-dev-dependencies, then analyze --lib-only --skip-if-not-supporting-dart-version), pass --skip-if-not-supporting-dart-version for stable too, and then remove the TODOs in both .repo_tool_config.yaml and multi_version_tasks.yaml.


# The list of external packages that are allowed as dependencies.
# All entries here must have an explanation for why they are here. See
Expand Down
4 changes: 4 additions & 0 deletions packages/flutter_hook_config/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## NEXT

* Updates minimum supported SDK version to Flutter 3.44/Dart 3.12.

## 0.1.0

* Initial release of `flutter_hook_config`: a `package:hooks` protocol extension
Expand Down
2 changes: 1 addition & 1 deletion packages/flutter_hook_config/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ repository: https://github.com/flutter/core-packages/tree/main/packages/flutter_
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A%20flutter_hook_config%22

environment:
sdk: ^3.10.0
sdk: ^3.12.0

dependencies:
hooks: ^2.0.0
Expand Down
4 changes: 4 additions & 0 deletions packages/flutter_template_images/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## NEXT

* Updates minimum supported SDK version to Flutter 3.44/Dart 3.12.

## 5.0.1

* Updates metadata for move to https://github.com/flutter/core-packages.
Expand Down
2 changes: 1 addition & 1 deletion packages/flutter_template_images/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+
version: 5.0.1

environment:
sdk: ^3.10.0
sdk: ^3.12.0

topics:
- assets
Expand Down
4 changes: 4 additions & 0 deletions packages/listen/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## NEXT

- Updates minimum supported SDK version to Flutter 3.44/Dart 3.12.

## 1.0.1

- Pushes stable version.
Expand Down
2 changes: 1 addition & 1 deletion packages/listen/example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ publish_to: none
version: 0.0.1

environment:
sdk: ^3.10.0
sdk: ^3.12.0

dependencies:
listen:
Expand Down
2 changes: 1 addition & 1 deletion packages/listen/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+
version: 1.0.1

environment:
sdk: ^3.10.0
sdk: ^3.12.0

dependencies:
meta: ^1.11.0
Expand Down
4 changes: 4 additions & 0 deletions packages/multicast_dns/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## NEXT

* Updates minimum supported SDK version to Flutter 3.44/Dart 3.12.

## 0.3.3+1

* Updates metadata for move to https://github.com/flutter/core-packages.
Expand Down
3 changes: 1 addition & 2 deletions packages/multicast_dns/lib/multicast_dns.dart
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@ typedef RawDatagramSocketFactory =
/// section 5.1 of [RFC 6762](https://tools.ietf.org/html/rfc6762).
class MDnsClient {
/// Create a new [MDnsClient].
MDnsClient({RawDatagramSocketFactory rawDatagramSocketFactory = RawDatagramSocket.bind})
: _rawDatagramSocketFactory = rawDatagramSocketFactory;
MDnsClient({this._rawDatagramSocketFactory = RawDatagramSocket.bind});

bool _starting = false;
bool _started = false;
Expand Down
2 changes: 1 addition & 1 deletion packages/multicast_dns/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+
version: 0.3.3+1

environment:
sdk: ^3.10.0
sdk: ^3.12.0

dependencies:
meta: ^1.3.0
Expand Down
4 changes: 4 additions & 0 deletions packages/standard_message_codec/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## NEXT

* Updates minimum supported SDK version to Flutter 3.44/Dart 3.12.

## 0.0.1+5

* Updates metadata for move to https://github.com/flutter/core-packages.
Expand Down
2 changes: 1 addition & 1 deletion packages/standard_message_codec/example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ version: 0.0.1
publish_to: none

environment:
sdk: ^3.10.0
sdk: ^3.12.0

dependencies:
standard_message_codec:
Expand Down
2 changes: 1 addition & 1 deletion packages/standard_message_codec/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen
version: 0.0.1+5

environment:
sdk: ^3.10.0
sdk: ^3.12.0

dev_dependencies:
test: ^1.16.0
Expand Down
4 changes: 4 additions & 0 deletions packages/vector_math/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## NEXT

* Updates minimum supported SDK version to Flutter 3.44/Dart 3.12.

## 2.4.4

* Replaces dynamic multiplication in `TransformFilter.filterInplace` with `Matrix4.transform3` to fix an analyzer error on newer Dart SDKs.
Expand Down
2 changes: 1 addition & 1 deletion packages/vector_math/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+
version: 2.4.4

environment:
sdk: ^3.10.0
sdk: ^3.12.0

dev_dependencies:
benchmark_harness: ^2.0.0
Expand Down
4 changes: 4 additions & 0 deletions third_party/packages/mustache_template/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## NEXT

* Updates minimum supported SDK version to Flutter 3.44/Dart 3.12.

## 2.0.6

* Adopts `code-excerpt` for the README's Dart snippets so they're validated
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Example code for the mustache_template package.
publish_to: none

environment:
sdk: ^3.10.0
sdk: ^3.12.0

dependencies:
mustache_template:
Expand Down
3 changes: 1 addition & 2 deletions third_party/packages/mustache_template/lib/src/parser.dart
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,10 @@ class TagType {
}

class Parser {
Parser(String source, String? templateName, String delimiters, {bool lenient = false})
Parser(String source, String? templateName, String delimiters, {this._lenient = false})
: _source = source,
_templateName = templateName,
_delimiters = delimiters,
_lenient = lenient,
_scanner = Scanner(source, templateName, delimiters);

final String _source;
Expand Down
8 changes: 3 additions & 5 deletions third_party/packages/mustache_template/lib/src/template.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,13 @@ class Template implements m.Template {
Template.fromSource(
this.source, {
bool lenient = false,
bool htmlEscapeValues = true,
this._htmlEscapeValues = true,
String? name,
m.PartialResolver? partialResolver,
this._partialResolver,
String delimiters = '{{ }}',
}) : _nodes = parser.parse(source, lenient, name, delimiters),
_lenient = lenient,
_htmlEscapeValues = htmlEscapeValues,
_name = name,
_partialResolver = partialResolver;
_name = name;

@override
final String source;
Expand Down
2 changes: 1 addition & 1 deletion third_party/packages/mustache_template/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+
version: 2.0.6

environment:
sdk: ^3.10.0
sdk: ^3.12.0

dev_dependencies:
test: ^1.16.5
Expand Down
Loading