Repository navigation
[ci] Update repo for 3.50 stable release - #51
Conversation
Applies `dart fix --code=prefer_initializing_formals`: with the language version now 3.12, the lint suggests private named parameters (new in Dart 3.12). Callers keep using the same argument names.
There was a problem hiding this comment.
Code Review
This pull request updates the minimum supported Dart SDK version from 3.10.0 to 3.12.0 across multiple packages, including updating their pubspec.yaml files, examples, and CHANGELOG.md files, as well as the repository configuration. Feedback suggests updating or removing an outdated comment in .repo_tool_config.yaml regarding legacy version analysis testing.
| # TODO(stuartmorgan): Set up legacy analysis in this repo. For now this matches | ||
| # the N-2 used in flutter/packages, but we aren't actually testing N-1 or N-2. | ||
| min_dart: '3.10.0' | ||
| min_dart: '3.12.0' |
There was a problem hiding this comment.
Removed the last half sentence.
There was a problem hiding this comment.
Should we remove the TODO comment entirely? Feel free to punt this to a follow-up PR if that makes things easier.
There was a problem hiding this comment.
I'll leave it for now, since legacy analysis still isn't set up in this repo. To handle it in a follow-up, we can move N-1/N-2 in multi_version_tasks.yaml to a legacy analysis job like flutter/packages has (remove-dev-dependencies, then analyze --lib-only --skip-if-not-supporting-dart-version), pass --skip-if-not-supporting-dart-version for stable too, and then remove the TODOs in both .repo_tool_config.yaml and multi_version_tasks.yaml.
|
Adding |
loic-sharma
left a comment
There was a problem hiding this comment.
LGTM. I'm not very familiar with this process, but I checked that this mirrors the docs.
Does the flutter/core-packages steps of Updating-Packages-repo-for-a-stable-release.md for the 3.50 stable release. This repo wasn't updated for 3.47, so this also catches up on that release:
main. The matrix previously covered only N-1 and stable; this adds N-2 as the doc describes.min_dartto 3.12.0 (the Dart version of Flutter 3.44.0, flutter/packages' new minimum), and updates all packages withupdate-min-sdk --flutter-min=3.44.0, run with the repo tooling from [ci] Update repo for 3.50 stable release packages#13628, which has the updated version mapping.NEXTCHANGELOG entries withupdate-release-info --version=next(no version bumps, per repo policy).Additional adjustments needed for CI with the updated versions:
dart fix --code=prefer_initializing_formalsinmulticast_dnsandmustache_template, whose language version moved to Dart 3.12, adopting private named parameters (this._foo; call-site argument names are unchanged).min_dartcomment in.repo_tool_config.yaml, since the matrix now covers N-1 and N-2.Companion to flutter/packages#13628.
There's no tracking issue for this routine post-release update.
Pre-Review Checklist
[vector_math]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2