Skip to content

[ci] Update repo for 3.50 stable release - #51

Merged
QuncCccccc merged 8 commits into
flutter:mainfrom
QuncCccccc:stable-3-50
Nov 12, 2026
Merged

QuncCccccc merged 8 commits into
flutter:mainfrom
QuncCccccc:stable-3-50

Conversation

@QuncCccccc

@QuncCccccc QuncCccccc commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Does the flutter/core-packages steps of Updating-Packages-repo-for-a-stable-release.md for the 3.50 stable release. This repo wasn't updated for 3.47, so this also catches up on that release:

  • Updates the multi-version analysis and test matrix to the Dart versions of flutter/packages' stable, N-1, and N-2 Flutter versions: 3.14.0 (Flutter 3.50.0), 3.13.7 (Flutter 3.47.9), and 3.12.2 (Flutter 3.44.9), plus main. The matrix previously covered only N-1 and stable; this adds N-2 as the doc describes.
  • Updates the Windows unit tests and the release action to Dart 3.14.0.
  • Raises min_dart to 3.12.0 (the Dart version of Flutter 3.44.0, flutter/packages' new minimum), and updates all packages with update-min-sdk --flutter-min=3.44.0, run with the repo tooling from [ci] Update repo for 3.50 stable release packages#13628, which has the updated version mapping.
  • Adds NEXT CHANGELOG entries with update-release-info --version=next (no version bumps, per repo policy).

Additional adjustments needed for CI with the updated versions:

  • Applies dart fix --code=prefer_initializing_formals in multicast_dns and mustache_template, whose language version moved to Dart 3.12, adopting private named parameters (this._foo; call-site argument names are unchanged).
  • Also removes the outdated "we aren't actually testing N-1 or N-2" note from the min_dart comment in .repo_tool_config.yaml, since the matrix now covers N-1 and N-2.

Companion to flutter/packages#13628.

There's no tracking issue for this routine post-release update.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

Applies `dart fix --code=prefer_initializing_formals`: with the language version now 3.12, the lint suggests private named parameters (new in Dart 3.12). Callers keep using the same argument names.
@QuncCccccc QuncCccccc added the override: no versioning needed Override the check requiring version bumps for most changes label Nov 11, 2026
@QuncCccccc
QuncCccccc marked this pull request as ready for review November 11, 2026 20:46

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum supported Dart SDK version from 3.10.0 to 3.12.0 across multiple packages, including updating their pubspec.yaml files, examples, and CHANGELOG.md files, as well as the repository configuration. Feedback suggests updating or removing an outdated comment in .repo_tool_config.yaml regarding legacy version analysis testing.

Comment thread .repo_tool_config.yaml
# TODO(stuartmorgan): Set up legacy analysis in this repo. For now this matches
# the N-2 used in flutter/packages, but we aren't actually testing N-1 or N-2.
min_dart: '3.10.0'
min_dart: '3.12.0'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment on lines 12-13 states that 'we aren't actually testing N-1 or N-2'. Since this PR updates the test matrix to include N-2, this comment is now outdated and should be updated or removed to reflect the new testing setup.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the last half sentence.

@loic-sharma loic-sharma Nov 12, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the TODO comment entirely? Feel free to punt this to a follow-up PR if that makes things easier.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it for now, since legacy analysis still isn't set up in this repo. To handle it in a follow-up, we can move N-1/N-2 in multi_version_tasks.yaml to a legacy analysis job like flutter/packages has (remove-dev-dependencies, then analyze --lib-only --skip-if-not-supporting-dart-version), pass --skip-if-not-supporting-dart-version for stable too, and then remove the TODOs in both .repo_tool_config.yaml and multi_version_tasks.yaml.

@QuncCccccc

Copy link
Copy Markdown
Contributor Author

Adding override: no versioning needed: raising the minimum SDK when the test matrix changes is version-exempt per the version policy. The dart fix changes don't change any public API, so they don't need a release either.

@loic-sharma loic-sharma left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm not very familiar with this process, but I checked that this mirrors the docs.

@QuncCccccc
QuncCccccc merged commit 8ef0d60 into flutter:main Nov 12, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants