Skip to content

Repository navigation

fix(corded-buffer): advance across empty corded slices #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lorenzhs merged 1 commit into from
Oct 5, 2026
Merged

fix(corded-buffer): advance across empty corded slices #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions cpp/src/arrow/corded_buffer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,8 @@ void CordedBuffer::Advance(size_t n) noexcept {
const auto& slice = slices_[slice_idx_];
const int64_t remaining_to_skip = n - skipped;
const int64_t this_slice_offset = std::exchange(slice_offset_, 0);
assert(this_slice_offset < static_cast<int64_t>(slice.size()));
assert(this_slice_offset <= static_cast<int64_t>(slice.size()));
const int64_t available_in_slice = slice.size() - this_slice_offset;
if (remaining_to_skip == available_in_slice) {
// We advanced just to the page boundary, need to advance to the next page
++slice_idx_;
return;
}
if (remaining_to_skip < available_in_slice) {
slice_offset_ = static_cast<int32_t>(remaining_to_skip + this_slice_offset);
return;
Expand Down
Loading