Repository navigation
fix(corded-buffer): advance across empty corded slices - #53
Merged
Merged
Conversation
lorenzhs
marked this pull request as ready for review
October 5, 2026 17:15
moshap-firebolt
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Parquet page-reader tests with an empty slice between header chunks asserted in
CordedBuffer::Advance()because its offset assertion rejects a zero-length slice.Summary
Allow an offset equal to the slice size and continue traversing at exact boundaries, so advancing skips consecutive empty slices and reaches the next nonempty slice or the end of the buffer.
Test Plan
Note
Low Risk
Narrow change to corded-buffer cursor advancement with no auth, I/O, or data-format surface area beyond fixing boundary handling for empty slices.
Overview
Fixes
CordedBuffer::Advance()so it no longer aborts when the cursor sits on zero-length slices (e.g. empty gaps between Parquet header chunks in page-reader tests).The debug assert now allows
slice_offset_equal toslice.size(), and the special case that returned immediately when skipping exactly to a slice boundary was removed. Advancing to the end of a slice now accumulates skipped bytes and keeps iterating, so leading, consecutive, and trailing empty slices are skipped until the next nonempty data or the buffer end.Reviewed by Cursor Bugbot for commit 2d87397. Bugbot is set up for automated code reviews on this repo. Configure here.