Skip to content

ci: install dependencies in the publish job (lerna is no longer on the runner image) - #712

Merged
abhis3 merged 1 commit into
mainfrom
ci/publish-job-install-deps
Nov 10, 2026
Merged

abhis3 merged 1 commit into
mainfrom
ci/publish-job-install-deps

Conversation

@abhis3

@abhis3 abhis3 commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Summary

The Publish (NPM) job in test.yml is currently broken on both publish paths, Wombat and OSS Exit Gate.

  • ubuntu-latest now runs ubuntu-26.04, and that image no longer ships a global lerna. The 24.04 image listed "Lerna 10.0.1".
  • The publish job never ran npm ci. scripts/publish.js → scripts/github.js runs lerna list, so it now fails with /bin/sh: 1: lerna: not found. See this run (attempt 2, ubuntu-26.04 image 20261101.186).
  • The last successful publish job (Oct 12, adapter-nextjs-v14.0.22) ran on ubuntu-24.04 image 20261004.327.

Changes

  1. Run npm ci in the publish job, right after Setup node and before the build artifacts are copied in. npm run publish then uses the repo's own lerna (^8.2.2), the same one the Build job uses. No workspace package has install-time scripts, so this doesn't rebuild anything. The manual publish-exit-gate.yml workflow already runs npm ci and has published through Exit Gate successfully.
  2. Keep the build artifact for 7 days instead of 1. The publish job waits for someone to approve the release environment, and it reuses the Build job's artifact. In the same run's first attempt, an approval two days after the push failed at Rsync Artifacts because the artifact had expired ("Found 0 artifact(s)").

Testing

  • The workflow YAML parses, and the publish job's steps are: checkout, setup-node, npm ci, download artifacts, rsync, publish.
  • The publish job only runs on main and on releases, so this PR can't run it. After merge, the merge commit's publish run makes a safe check: it changes no package, so it should run the full Exit Gate path and skip the manifest upload.

ubuntu-latest now runs ubuntu-26.04, which doesn't ship a global lerna (the 24.04 image had Lerna 10.0.1). The publish job never ran npm ci, so scripts/publish.js now fails with 'lerna: not found' in both the Wombat and the Exit Gate paths. Run npm ci before the build artifacts are copied in, so the repo's own lerna is used.

Also keep the build artifact for 7 days instead of 1. The publish job waits for a human to approve the release environment, and an approval more than a day after the push failed at 'Rsync Artifacts' because the artifact had expired.
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@abhis3
abhis3 marked this pull request as ready for review November 9, 2026 23:51
@abhis3
abhis3 merged commit 2e8dedc into main Nov 10, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants