Repository navigation
ci: install dependencies in the publish job (lerna is no longer on the runner image) - #712
Merged
Merged
Conversation
ubuntu-latest now runs ubuntu-26.04, which doesn't ship a global lerna (the 24.04 image had Lerna 10.0.1). The publish job never ran npm ci, so scripts/publish.js now fails with 'lerna: not found' in both the Wombat and the Exit Gate paths. Run npm ci before the build artifacts are copied in, so the repo's own lerna is used. Also keep the build artifact for 7 days instead of 1. The publish job waits for a human to approve the release environment, and an approval more than a day after the push failed at 'Rsync Artifacts' because the artifact had expired.
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
abhis3
marked this pull request as ready for review
November 9, 2026 23:51
abhis3
requested review from
Yuangwang,
annajowang,
falahat and
leoortizz
as code owners
November 9, 2026 23:51
falahat
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Publish (NPM)job intest.ymlis currently broken on both publish paths, Wombat and OSS Exit Gate.ubuntu-latestnow runs ubuntu-26.04, and that image no longer ships a globallerna. The 24.04 image listed "Lerna 10.0.1".npm ci.scripts/publish.js→scripts/github.jsrunslerna list, so it now fails with/bin/sh: 1: lerna: not found. See this run (attempt 2, ubuntu-26.04 image20261101.186).adapter-nextjs-v14.0.22) ran on ubuntu-24.04 image20261004.327.Changes
npm ciin the publish job, right afterSetup nodeand before the build artifacts are copied in.npm run publishthen uses the repo's own lerna (^8.2.2), the same one the Build job uses. No workspace package has install-time scripts, so this doesn't rebuild anything. The manualpublish-exit-gate.ymlworkflow already runsnpm ciand has published through Exit Gate successfully.releaseenvironment, and it reuses the Build job's artifact. In the same run's first attempt, an approval two days after the push failed atRsync Artifactsbecause the artifact had expired ("Found 0 artifact(s)").Testing
npm ci, download artifacts, rsync, publish.mainand on releases, so this PR can't run it. After merge, the merge commit's publish run makes a safe check: it changes no package, so it should run the full Exit Gate path and skip the manifest upload.