Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the publishing process in scripts/publish.js by removing the useOssGate flag and the legacy wombatDressingRoomTokens configuration. The script now exclusively uses the Exit Gate workflow, always ensuring the Exit Gate .npmrc is configured, deleting publishConfig from package.json, and generating the Exit Gate manifest. There are no review comments, and I have no feedback to provide.
abhis3
marked this pull request as ready for review
November 10, 2026 20:04
abhis3
requested review from
Yuangwang,
annajowang,
falahat and
leoortizz
as code owners
November 10, 2026 20:04
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo now publishes through OSS Exit Gate (the
NPM_PUBLISH_VIArepository variable isexit-gate), so nothing goes through Wombat Dressing Room anymore, and Wombat stops working in January 2027. This removes the old path and makes Exit Gate the only one:test.yml: drops the WombatPublishstep with its npm token secrets, theregistry-urlthat only that step needed, and theNPM_PUBLISH_VIAconditions on the Exit Gate steps.scripts/publish.js: drops the Wombat tokens, the directnpm publishto npm with provenance, and the opt-in switch (--use-oss-gate,NPM_PUBLISH_VIA,USE_OSS_GATE). It always stages to Exit Gate's Artifact Registry repository and writes the manifest.publish-exit-gate.yml: stops passing the unused--use-oss-gateflag.What gets published doesn't change: canaries on pushes to main,
latest/nexton release tags (only the tagged package), and manual runs ofpublish-exit-gate.yml. Unreleased packages are still skipped.Exit Gate is already publishing from this repo
These runs went through the same Exit Gate steps that this PR keeps, one run for each way a publish starts:
test.yml)build-v0.1.8-rc.0@apphosting/build@0.1.8-rc.0and uploaded the manifest. About 6 minutes later Exit Gate published it to npm asgoogle-wombot, under thenexttag.lateststayed at 0.1.7.test.yml)npm ci, the Exit Gate sign-in and the Artifact Registry login passed, and the Wombat step was skipped. No package changed, so the manifest upload was skipped.publish-exit-gate.yml)@apphosting/common@0.0.9-canary.857f6b2.42700120038.1to npm asgoogle-wombot, under thecanarytag.To check npm yourself:
npm view @apphosting/build@0.1.8-rc.0 _npmUser.nameprintsgoogle-wombot, andnpm view @apphosting/build dist-tagsshowsnext: 0.1.8-rc.0andlatest: 0.1.7.After this merges, these can be deleted: the
ADAPTER_ANGULAR_NPM_TOKEN,ADAPTER_ASTRO_NPM_TOKEN,ADAPTER_COMMON_NPM_TOKEN,ADAPTER_NEXTJS_NPM_TOKEN,FIREBASE_FRAMEWORKS_NPM_TOKENandPERSONAL_NPM_TOKENsecrets, and theNPM_PUBLISH_VIAvariable.Testing
Dry runs of
scripts/publish.js(PUBLISH_DRY_RUN=true) forcanarytag, with@google-cloud/adapter-nextjsleft outbuild-v0.1.8release tag: only@apphosting/build@0.1.8, taglatest@apphosting/common: per-run canary suffix@google-cloud/adapter-nextjs: failsESLint and Prettier pass.