Skip to content

Add Table row status theming target - #5754

Closed
rubyycheung wants to merge 1 commit into
codex/theme-palette-contractfrom
codex/table-row-status-theming-target
Closed

Add Table row status theming target#5754
rubyycheung wants to merge 1 commit into
codex/theme-palette-contractfrom
codex/table-row-status-theming-target

Conversation

@rubyycheung

@rubyycheung rubyycheung commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • adds an astryx-table-row-status theming target with color and presentation visual props
  • keeps dot/icon behavior caller-controlled while exposing the wrapper for scoped theme overrides
  • documents the new target for Table and useTableRowStatus

Stack

Validation

  • pnpm vitest run packages/core/src/Table/plugins/rowStatus/useTableRowStatus.test.tsx
  • pre-commit checks from commit hook

@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
astryx Ready Ready Preview Aug 31, 2026 5:24am

Request Review

@xinzi-bot xinzi-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks — this adds the row-status theme target cleanly, preserves default color fallbacks, and documents the new surface. @imdreamrunner, this looks ready for your approval.

[Automated review]

@rubyycheung

Copy link
Copy Markdown
Contributor Author

Superseded by #5848, which contains the row-status theming target on a standalone branch based directly on main.

While rebasing, the replacement preserved newer main behavior where success, warning, and error use themed semantic icons by default. The theming target now layers on top of that behavior instead of replacing it.

@rubyycheung rubyycheung closed this Sep 1, 2026
@github-actions
github-actions Bot deleted the codex/table-row-status-theming-target branch September 2, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants