Skip to content

Refine Neutral theme color roles - #5752

Open
rubyycheung wants to merge 7 commits into
codex/table-row-status-theming-targetfrom
codex/neutral-theme-gold-star-colors
Open

Refine Neutral theme color roles#5752
rubyycheung wants to merge 7 commits into
codex/table-row-status-theming-targetfrom
codex/neutral-theme-gold-star-colors

Conversation

@rubyycheung

@rubyycheung rubyycheung commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • stacks on feat(theme): add approved tonal palette metadata #5668 and Add Table row status theming target #5754 so this PR only carries Neutral theme decisions
  • uses the approved tonal palette metadata instead of redefining a local palette contract
  • adds Neutral-scoped reusable role tokens for filled status colors and tint overlays
  • remaps the approved affected Neutral component roles: Badge, StatusDot, AvatarStatusDot, Stepper, Table row status, Banner tint overlays, and ProgressBar

Notes

  • Custom token names are scoped to the Neutral theme tokens object; they are not added to core defaults.
  • Row-status theming infrastructure now lives in Add Table row status theming target #5754.
  • Removed the messy stacked behavior change that injected warning icons automatically; row status shape behavior stays caller-provided.
  • Did not include selectable-card, token, chat-message, or chat-tool overrides.

Validation

  • pnpm vitest run packages/core/src/Table/plugins/rowStatus/useTableRowStatus.test.tsx
  • pnpm -F @astryxdesign/core build
  • pnpm -F @astryxdesign/theme-neutral build
  • pnpm bundle:cli-themes
  • pnpm check:sync
  • pnpm check:changesets
  • pnpm check:package-boundaries
  • pre-commit full repo gates

@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
astryx Ready Ready Preview Aug 31, 2026 3:40pm

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 31, 2026
@github-actions github-actions Bot added the needs:code-review High-risk change (new package/component/API) — needs human code review before merge label Aug 31, 2026
@rubyycheung
rubyycheung force-pushed the codex/neutral-theme-gold-star-colors branch from 4298043 to 99f0dd6 Compare August 31, 2026 05:01
github-actions Bot added a commit that referenced this pull request Aug 31, 2026
@rubyycheung
rubyycheung force-pushed the codex/neutral-theme-gold-star-colors branch from 99f0dd6 to e90eba0 Compare August 31, 2026 05:24
@rubyycheung
rubyycheung changed the base branch from main to codex/table-row-status-theming-target August 31, 2026 05:24
@rubyycheung
rubyycheung force-pushed the codex/neutral-theme-gold-star-colors branch 3 times, most recently from 6082b6f to 5940255 Compare August 31, 2026 05:35
@rubyycheung
rubyycheung force-pushed the codex/neutral-theme-gold-star-colors branch from 5940255 to 4e3970c Compare August 31, 2026 05:43

@xinzi-bot xinzi-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new role-token direction looks good, but Stepper and ProgressBar warning still skip the warning fill mapping, and Stepper’s fallback is only about 1.9:1. This visual PR also needs exact-head light/dark screenshots. Please add both warning overrides and the required visual evidence.

[Automated review]

@cixzhang cixzhang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neutral theme updates look good but here's some button updates mixed in that seem unintentional. Could we clean those up? Then the rest is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. needs:code-review High-risk change (new package/component/API) — needs human code review before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants