Refine Neutral theme color roles - #5752
Open
rubyycheung wants to merge 7 commits into
Open
Conversation
rubyycheung
requested review from
cixzhang,
humbertovirtudes,
imdreamrunner and
josephfarina
as code owners
August 31, 2026 04:57
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rubyycheung
force-pushed
the
codex/neutral-theme-gold-star-colors
branch
from
August 31, 2026 05:01
4298043 to
99f0dd6
Compare
rubyycheung
force-pushed
the
codex/neutral-theme-gold-star-colors
branch
from
August 31, 2026 05:24
99f0dd6 to
e90eba0
Compare
rubyycheung
changed the base branch from
main
to
codex/table-row-status-theming-target
August 31, 2026 05:24
rubyycheung
force-pushed
the
codex/neutral-theme-gold-star-colors
branch
3 times, most recently
from
August 31, 2026 05:35
6082b6f to
5940255
Compare
rubyycheung
force-pushed
the
codex/neutral-theme-gold-star-colors
branch
from
August 31, 2026 05:43
5940255 to
4e3970c
Compare
xinzi-bot
reviewed
Aug 31, 2026
xinzi-bot
left a comment
There was a problem hiding this comment.
The new role-token direction looks good, but Stepper and ProgressBar warning still skip the warning fill mapping, and Stepper’s fallback is only about 1.9:1. This visual PR also needs exact-head light/dark screenshots. Please add both warning overrides and the required visual evidence.
[Automated review]
rubyycheung
force-pushed
the
codex/neutral-theme-gold-star-colors
branch
from
August 31, 2026 05:49
4e3970c to
9267613
Compare
rubyycheung
force-pushed
the
codex/neutral-theme-gold-star-colors
branch
from
August 31, 2026 06:00
9267613 to
ceabacf
Compare
This was referenced Aug 31, 2026
cixzhang
requested changes
Aug 31, 2026
cixzhang
left a comment
Contributor
There was a problem hiding this comment.
Neutral theme updates look good but here's some button updates mixed in that seem unintentional. Could we clean those up? Then the rest is good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
Validation