[build-tools] Use lower 980px Android preview resolution - #4326
Open
krystofwoldrich-agent wants to merge 5 commits into
Open
[build-tools] Use lower 980px Android preview resolution#4326krystofwoldrich-agent wants to merge 5 commits into
krystofwoldrich-agent wants to merge 5 commits into
Conversation
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> Co-authored-by: Codex <codex@openai.com>
krystofwoldrich
changed the title
krystofwoldrich
marked this pull request as ready for review
September 1, 2026 07:02
szdziedzic
approved these changes
Sep 1, 2026
szdziedzic
left a comment
szdziedzic
left a comment
Contributor
There was a problem hiding this comment.
One of the problems we had in serve sim is that we did multiple unneeded copies of whole high res pixel matrix. I'm not sure if we have some optimization to do here for it as well.
Contributor
|
Yes, there are similar improvement to be made on the serve-emu side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android expo-device-hub previews use a 1280 px maximum dimension while iOS serve-sim previews use 960 px. Matching the lower cap reduces Android streaming bandwidth and improves the stream fps. (not stable 60 fps yet)