[eas-cli] Avoid GraphQL argument type collisions - #4328
Merged
Conversation
Separate generated parent type and field names so newly namespaced Observe fields cannot collide with legacy flat field argument types. Co-authored-by: Codex <codex@openai.com>
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4328 +/- ##
=========================================
Coverage 65.48% 65.48%
=========================================
Files 1060 1060
Lines 49302 49302
Branches 10437 10494 +57
=========================================
Hits 32282 32282
+ Misses 16904 15597 -1307
- Partials 116 1423 +1307 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
krystofwoldrich
requested review from
AHGIJMKLKKZNPJKQR,
FiberJW,
sjchmiela,
szdziedzic and
tchayen
September 2, 2026 14:44
kadikraman
approved these changes
Sep 2, 2026
kadikraman
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix, and sorry for the hassle!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #4326’s GraphQL verification job started failing after the production schema added namespaced Observe fields. GraphQL Code Generator concatenates a parent type and field name for generated argument types, so
AppObserve.navigationRoutesandAppObserveNavigation.routesboth becameAppObserveNavigationRoutesArgs. Four Overview fields collided in the same way.Failing job: https://github.com/expo/eas-cli/actions/runs/33641026834/job/100285705688?pr=4326
How
Enable
addUnderscoreToArgsTypeto preserve the parent/field boundary, regenerate the checked-in GraphQL types, and update the two handwritten imports of the renamed realtime-logs argument type.Test Plan
yarn workspace eas-cli verify-graphql-code(passes against the current production schema)yarn workspace eas-cli typecheck-for-buildyarn workspace eas-cli test src/utils/__tests__/centrifuge-test.ts --runInBandyarn lintyarn oxfmt --check packages/eas-cli/graphql-codegen.ts packages/eas-cli/src/graphql/generated.ts packages/eas-cli/src/graphql/mutations/RealtimeLogsMutation.ts packages/eas-cli/src/utils/centrifuge.ts