Skip to content

[eas-cli] carry the serve-sim session token in simulator preview links - #4312

Open
gwdp wants to merge 1 commit into
mainfrom
gwdp/serve-sim-preview-token-cli
Open

[eas-cli] carry the serve-sim session token in simulator preview links#4312
gwdp wants to merge 1 commit into
mainfrom
gwdp/serve-sim-preview-token-cli

Conversation

@gwdp

@gwdp gwdp commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Caution

blocked by https://github.com/expo/universe/pull/30628 (needs gql regen)

Why

eas simulator and eas simulator get print the preview link. Once the preview is gated by expo/serve-sim#49, a bare link returns 401, so the printed instructions stop working. This affects every iOS session type, not only serve-sim ones.

How

Test Plan

  • CI

@gwdp
gwdp force-pushed the gwdp/serve-sim-preview-token-cli branch from a5d954d to 2d9cdf2 Compare August 31, 2026 01:45
@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.51%. Comparing base (4b1e5a7) to head (9f5c20f).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4312      +/-   ##
==========================================
+ Coverage   65.38%   65.51%   +0.14%     
==========================================
  Files        1058     1060       +2     
  Lines       49090    49307     +217     
  Branches    10353    10438      +85     
==========================================
+ Hits        32095    32301     +206     
- Misses      16879    16890      +11     
  Partials      116      116              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gwdp
gwdp force-pushed the gwdp/serve-sim-preview-token-cli branch from 2d9cdf2 to c2cf041 Compare August 31, 2026 15:43
@gwdp
gwdp requested a review from szdziedzic August 31, 2026 16:27
@gwdp
gwdp force-pushed the gwdp/serve-sim-preview-token-cli branch 2 times, most recently from 98804dd to c2ad60b Compare August 31, 2026 21:29
@linear-code

linear-code Bot commented Aug 31, 2026

Copy link
Copy Markdown

ENG-22303

@gwdp
gwdp marked this pull request as ready for review August 31, 2026 21:44
@github-actions

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
packages/eas-cli/** @douglowder

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

@gwdp
gwdp force-pushed the gwdp/serve-sim-preview-token-cli branch from c2ad60b to 9f5c20f Compare September 2, 2026 05:36
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant