[eas-cli] carry the serve-sim session token in simulator preview links - #4312
Open
gwdp wants to merge 1 commit into
Open
[eas-cli] carry the serve-sim session token in simulator preview links#4312gwdp wants to merge 1 commit into
gwdp wants to merge 1 commit into
Conversation
gwdp
force-pushed
the
gwdp/serve-sim-preview-token-cli
branch
from
August 31, 2026 01:45
a5d954d to
2d9cdf2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4312 +/- ##
==========================================
+ Coverage 65.38% 65.51% +0.14%
==========================================
Files 1058 1060 +2
Lines 49090 49307 +217
Branches 10353 10438 +85
==========================================
+ Hits 32095 32301 +206
- Misses 16879 16890 +11
Partials 116 116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gwdp
force-pushed
the
gwdp/serve-sim-preview-token-cli
branch
from
August 31, 2026 15:43
2d9cdf2 to
c2cf041
Compare
gwdp
force-pushed
the
gwdp/serve-sim-preview-token-cli
branch
2 times, most recently
from
August 31, 2026 21:29
98804dd to
c2ad60b
Compare
gwdp
marked this pull request as ready for review
August 31, 2026 21:44
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
gwdp
force-pushed
the
gwdp/serve-sim-preview-token-cli
branch
from
September 2, 2026 05:36
c2ad60b to
9f5c20f
Compare
|
✅ Thank you for adding the changelog entry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
blocked by https://github.com/expo/universe/pull/30628 (needs gql regen)
Why
eas simulatorandeas simulator getprint the preview link. Once the preview is gated by expo/serve-sim#49, a bare link returns 401, so the printed instructions stop working. This affects every iOS session type, not only serve-sim ones.How
?token=when there is one. All four print sites go through the sameformatPreviewUrlhelper.Test Plan