[eas-cli] gate device-run-session serve-sim with the session token - #4306
[eas-cli] gate device-run-session serve-sim with the session token#4306gwdp wants to merge 1 commit into
Conversation
29e0327 to
3a32d5c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## gwdp/serve-sim-preview-token-cli #4306 +/- ##
====================================================================
- Coverage 65.51% 65.44% -0.07%
====================================================================
Files 1060 1058 -2
Lines 49307 49113 -194
Branches 10438 10362 -76
====================================================================
- Hits 32301 32137 -164
+ Misses 16890 16860 -30
Partials 116 116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
74fa11b to
d48b193
Compare
szdziedzic
left a comment
There was a problem hiding this comment.
[P1] EAS CLI prints preview URLs without the token. The CLI query still requests only previewUrl/webPreviewUrl, then prints the bare URL. Gated serve-sim returns 401 for those links. Request previewToken/webPreviewToken in DeviceRunSessionQuery.ts, regenerate types, and append ?token= when formatting preview instructions. This affects every iOS session type; serve-sim-only sessions become unusable from the CLI.
d48b193 to
96e96aa
Compare
Yep, I inverted order here; expo/universe#30570 was coming, but I missed that it needs to be before this. Deploy order: #30628 → #30571 → serve-sim#49 publish → #4312 → #4306. |
96e96aa to
cd68117
Compare
c2cf041 to
98804dd
Compare
cd68117 to
a006de4
Compare
98804dd to
c2ad60b
Compare
a006de4 to
70244c4
Compare
c2ad60b to
9f5c20f
Compare
70244c4 to
774696e
Compare
|
✅ Thank you for adding the changelog entry! |
Why
serve-sim can now require a session token before it serves anything (assuming expo/serve-sim#49 merge). This turns that on for device run sessions.
How
Pass
--require-tokenwhen we start serve-sim, then carry the token:previewTokenorwebPreviewToken; Usage on expo/universe#30571/metricsstream we collect, which is gated nowNeeds a serve-sim release with the flag first. An older serve-sim rejects the unknown option and will not start, so this should land after that publishes.
Test Plan