Add aws_icons_bucket setting - #89
Merged
Merged
Conversation
The website needs to read the icons manifest straight out of the bucket, rather than going back out through Cloudflare for it, so the manifest doesn't need to be public. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NCycuWDzu2wXg9RbJsBZUP
The latest images require a licence, so the service container quits with "License activation failed" before the tests get a chance to run. 2.3.2 is what the website pins. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NCycuWDzu2wXg9RbJsBZUP
The test-reporter download 404s now that Code Climate has retired it, so the step fails before the tests get to run. The upload step was dead anyway: it gates on refs/heads/master and we're on main. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NCycuWDzu2wXg9RbJsBZUP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The website needs to read the icons manifest (exercism/website-icons#217) straight out of the bucket rather than going back out through Cloudflare for it, which means the manifest doesn't need to be public.
Matching DynamoDB config row to follow in terraform.
🤖 Generated with Claude Code
https://claude.ai/code/session_01NCycuWDzu2wXg9RbJsBZUP