Add aws_test_runners_bucket setting - #90
Merged
Merged
Conversation
The website serves the client-side test runner artifacts - the wasm kernel, and the per-language sysroots and runner tarballs - from its own origin, reading them out of this bucket. It has to be the website's own origin because the editor boots the kernel in a worker, and `new Worker()` refuses a cross-origin script URL. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015v94EHpgxqrdVPdkt7KaWk
Without this the bucket only exists in production, so a local website has nothing to read and the editor silently falls back to server-side runs - which looks identical to the feature not working. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015v94EHpgxqrdVPdkt7KaWk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The website serves the client-side test runner artifacts — the wasm kernel, and the per-language sysroots and runner tarballs — from its own origin, reading them out of this bucket.
It has to be the website's own origin: the editor boots the kernel in a Web Worker, and
new Worker()refuses a cross-origin script URL. No header lifts that, so the assets host isn't an option, andexercism.orgresolves to the ALB rather than CloudFront, so the path can't be rerouted at the edge either. The app reads from S3 and serves the bytes itself; Cloudflare caches the result, so S3 is read roughly once per edge location per release.Two commits:
local.ymlandci.yml— same shape as Add aws_icons_bucket setting #89, which addedaws_icons_bucket.setup_exercism_local_aws, so a local website has something to read. Without it the editor falls back to server-side runs, which looks identical to the feature not working.Version bump left out, as in #89.
🤖 Generated with Claude Code
https://claude.ai/code/session_015v94EHpgxqrdVPdkt7KaWk