Repository navigation
DeviceManager: use gala's brightness interface - #301
Merged
leolost2605 merged 25 commits intoNov 18, 2026
Merged
Conversation
flodavid
reviewed
Aug 30, 2026
garaevdi
force-pushed
the
gala-brightness-interface
branch
2 times, most recently
from
August 30, 2026 17:28
8ae12b5 to
908399e
Compare
garaevdi
force-pushed
the
gala-brightness-interface
branch
from
August 30, 2026 17:40
908399e to
8a12a7c
Compare
leolost2605
requested changes
Sep 4, 2026
leolost2605
left a comment
Member
There was a problem hiding this comment.
Works great with elementary/gala#2916 thanks! I left a few comments
leolost2605
requested changes
Sep 22, 2026
garaevdi
force-pushed
the
gala-brightness-interface
branch
from
September 24, 2026 20:15
ceb59d7 to
58955ad
Compare
leolost2605
requested changes
Sep 30, 2026
garaevdi
force-pushed
the
gala-brightness-interface
branch
from
October 3, 2026 09:18
58955ad to
be83482
Compare
garaevdi
force-pushed
the
gala-brightness-interface
branch
from
October 3, 2026 09:30
be83482 to
3b4e913
Compare
leolost2605
requested changes
Oct 3, 2026
leolost2605
left a comment
Member
There was a problem hiding this comment.
A few nits apart from that LGTM :)
So there would be no warning when we are trying to scroll on top of indicator while there is no suitable monitors with brightness control
garaevdi
force-pushed
the
gala-brightness-interface
branch
from
October 9, 2026 21:35
3b4e913 to
0f63778
Compare
Contributor
Author
|
Sry, fixed small issue I noticed during debugging gala's BrightnessManager😅️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #296
Requires elementary/gala#2916