Skip to content

DeviceManager: use gala's brightness interface - #301

Merged
leolost2605 merged 25 commits into
elementary:mainfrom
garaevdi:gala-brightness-interface
Nov 18, 2026
Merged

leolost2605 merged 25 commits into
elementary:mainfrom
garaevdi:gala-brightness-interface

Conversation

@garaevdi

@garaevdi garaevdi commented Jul 17, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #296
Requires elementary/gala#2916

@zeebok
zeebok requested a review from a team July 25, 2026 16:16
@ryonakano ryonakano added this to OS 9 Jul 28, 2026
@ryonakano ryonakano moved this to In progress in OS 9 Jul 28, 2026
@ryonakano ryonakano moved this from In progress to Needs Review in OS 9 Jul 28, 2026
Comment thread src/Widgets/ScreenBrightness.vala Resolved
@garaevdi
garaevdi force-pushed the gala-brightness-interface branch 2 times, most recently from 8ae12b5 to 908399e Compare August 30, 2026 17:28
@garaevdi
garaevdi force-pushed the gala-brightness-interface branch from 908399e to 8a12a7c Compare August 30, 2026 17:40

@leolost2605 leolost2605 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great with elementary/gala#2916 thanks! I left a few comments

Comment thread src/Services/DeviceManager.vala Resolved
Comment thread src/Widgets/ScreenBrightness.vala Resolved
Comment thread src/Indicator.vala Resolved
Comment thread src/Indicator.vala Resolved
@zeebok
zeebok requested a review from leolost2605 September 21, 2026 05:14

@leolost2605 leolost2605 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments :)

Comment thread src/Services/BrightnessManager.vala Resolved
Comment thread src/Services/BrightnessManager.vala Resolved
Comment thread src/Services/BrightnessManager.vala Resolved
Comment thread src/Widgets/PopoverWidget.vala Resolved
Comment thread src/Widgets/ScreenBrightnessList.vala Resolved
Comment thread src/Widgets/ScreenBrightnessList.vala Resolved
Comment thread src/Widgets/ScreenBrightnessRow.vala Resolved
Comment thread src/Widgets/ScreenBrightnessList.vala Resolved
Comment thread src/Widgets/ScreenBrightnessRow.vala Resolved
@garaevdi
garaevdi force-pushed the gala-brightness-interface branch from ceb59d7 to 58955ad Compare September 24, 2026 20:15
Comment thread src/Services/BrightnessManager.vala Resolved
Comment thread src/Services/BrightnessManager.vala Resolved
Comment thread src/Widgets/ScreenBrightnessList.vala Resolved
Comment thread src/Widgets/ScreenBrightnessRow.vala Resolved
Comment thread src/Widgets/ScreenBrightnessRow.vala Resolved
Comment thread src/Indicator.vala Resolved
Comment thread src/Indicator.vala Resolved
Comment thread src/Indicator.vala Resolved
Comment thread src/Widgets/ScreenBrightnessList.vala Resolved
Comment thread src/Indicator.vala Resolved
@garaevdi
garaevdi force-pushed the gala-brightness-interface branch from 58955ad to be83482 Compare October 3, 2026 09:18
@garaevdi
garaevdi force-pushed the gala-brightness-interface branch from be83482 to 3b4e913 Compare October 3, 2026 09:30

@leolost2605 leolost2605 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits apart from that LGTM :)

Comment thread src/Services/BrightnessManager.vala Resolved
Comment thread src/Services/BrightnessManager.vala Resolved
Comment thread src/Widgets/PopoverWidget.vala Resolved
Comment thread src/Widgets/ScreenBrightnessList.vala Resolved
Comment thread src/Widgets/ScreenBrightnessRow.vala Resolved
Comment thread src/Widgets/ScreenBrightnessRow.vala Resolved
Comment thread src/Widgets/ScreenBrightnessRow.vala Resolved
Comment thread src/Widgets/ScreenBrightnessRow.vala Resolved
@garaevdi
garaevdi force-pushed the gala-brightness-interface branch from 3b4e913 to 0f63778 Compare October 9, 2026 21:35

@leolost2605 leolost2605 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@garaevdi

Copy link
Copy Markdown
Contributor Author

Sry, fixed small issue I noticed during debugging gala's BrightnessManager😅️

@leolost2605
leolost2605 merged commit d17362e into elementary:main Nov 18, 2026
2 of 4 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in OS 9 Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Brightness control doesn't work with mutter-49+

4 participants