Skip to content

Use gala's brightness interface - #301

Open
garaevdi wants to merge 1 commit into
elementary:mainfrom
garaevdi:gala-brightness-interface
Open

garaevdi wants to merge 1 commit into
elementary:mainfrom
garaevdi:gala-brightness-interface

Conversation

@garaevdi

Copy link
Copy Markdown

Fixes #300

Almost 1:1 copy of elementary/panel-power#301

@leolost2605
leolost2605 force-pushed the gala-brightness-interface branch from c8a90b7 to 0f5ec27 Compare November 19, 2026 11:33

@leolost2605 leolost2605 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation LGTM, but let's see if @elementary/ux has something to say :)

@leolost2605
leolost2605 requested a review from a team November 19, 2026 11:34
@leolost2605

Copy link
Copy Markdown
Member

And there's a little linter error :)

@jumpyvi

jumpyvi commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

The slider does work perfectly, but I'm not sure what the "auto adjust brightness" toggle is supposed to be doing?

selection_mode = Gtk.SelectionMode.NONE,
show_separators = true
};
list_box.add_css_class (Granite.STYLE_CLASS_RICH_LIST);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rich list is deprecated. We should use granite list item instead

show_separators = true
};
list_box.add_css_class (Granite.STYLE_CLASS_RICH_LIST);
list_box.add_css_class (Granite.STYLE_CLASS_FRAME);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frame is also deprecated. Should be CARD instead

@danirabbit danirabbit added this to OS 9 Nov 19, 2026
@danirabbit danirabbit moved this to Needs Review in OS 9 Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs Review

Development

Successfully merging this pull request may close these issues.

The brightness slider doesn't work

4 participants