Repository navigation
Conversation
leolost2605
force-pushed
the
gala-brightness-interface
branch
from
November 19, 2026 11:33
c8a90b7 to
0f5ec27
Compare
leolost2605
approved these changes
Nov 19, 2026
leolost2605
left a comment
Member
There was a problem hiding this comment.
Implementation LGTM, but let's see if @elementary/ux has something to say :)
Member
|
And there's a little linter error :) |
Member
|
The slider does work perfectly, but I'm not sure what the "auto adjust brightness" toggle is supposed to be doing? |
danirabbit
requested changes
Nov 19, 2026
| selection_mode = Gtk.SelectionMode.NONE, | ||
| show_separators = true | ||
| }; | ||
| list_box.add_css_class (Granite.STYLE_CLASS_RICH_LIST); |
Member
There was a problem hiding this comment.
Rich list is deprecated. We should use granite list item instead
| show_separators = true | ||
| }; | ||
| list_box.add_css_class (Granite.STYLE_CLASS_RICH_LIST); | ||
| list_box.add_css_class (Granite.STYLE_CLASS_FRAME); |
Member
There was a problem hiding this comment.
Frame is also deprecated. Should be CARD instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #300
Almost 1:1 copy of elementary/panel-power#301