fix: add reset action for network proxy edits - #1893
Open
neptune-me wants to merge 2 commits into
Open
Conversation
neptune-me
marked this pull request as ready for review
September 2, 2026 21:04
Douglasymlai
approved these changes
Sep 3, 2026
Douglasymlai
left a comment
Contributor
There was a problem hiding this comment.
@neptune-me Thanks for your contribution. LGTM
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Related Issue
Closes #1728
Description
Adds a Reset action for unsaved Network Proxy edits.
setting.resettranslation.Testing Evidence (REQUIRED)
Automated validation:
npm test -- test/unit/components/GeneralSettingsProxy.test.tsx— 1 test file passed, 9 tests passed.npm run type-check— passed.npx eslint src/components/Settings/General/index.tsx test/unit/components/GeneralSettingsProxy.test.tsx --no-warn-ignored— passed.npm run check:design-token-usage— passed.git diff --check— passed.Focused tests cover loading a saved or empty proxy, editing and resetting without persistence writes, successful and failed save baselines, invalid URLs, whitespace-only edits, saving an empty proxy, and disabling Reset while a save is in flight.
Manual macOS verification:
Confirm the saved proxy loads with Save and Reset disabled.
Edit the proxy and confirm Save and Reset become enabled.
Click Reset and confirm the saved value is restored.
Save a valid edit and confirm Restart to Apply appears.
Attach a screenshot or screen recording below.
https://drive.google.com/file/d/1vLOe4r7cfVhKAjO5--k3NpZ8L8SlfcNJ/view?usp=sharing
I have included human-verified testing evidence in this PR.
This PR includes frontend/UI changes, and I attached screenshot(s) or screen recording(s).
No frontend/UI changes in this PR.
What is the purpose of this pull request?
Contribution Guidelines Acknowledgement